Integrate pull script with CDK. #103
Conversation
bryce-shang
force-pushed
the
integrate-pull-script
branch
from
e7d9b51 to
aa2e673
Compare
bryce-shang
force-pushed
the
integrate-pull-script
branch
from
aa2e673 to
c044042
Compare
tests/ci/cdk/README.md
Outdated
| ``` | ||
| $ ./run-cdk.sh {aws-account-id} {region} {github-repo-owner} {github-repo-name} {ACTION} | ||
| ./run-cdk.sh --action deploy-ci --github-access-token 123456 |
There was a problem hiding this comment.
I'm assuming that --github-access-token is something that the user provides? If so, I think it would make it more clear to have them set an environment variable with their token and then use that. Aren't we already using an environment variable somewhere with the user's personal github access token?
export GITHUB_ACCESS_TOKEN=...
./run-cdk.sh --action deploy-ci --github-access-token ${GITHUB_ACCESS_TOKEN}
There was a problem hiding this comment.
Previously, to connect AWS CodeBuild with GitHub, personal GitHub access token was used. Now, it's replaced with GitHub OAuth. Besides, this new access token needs read:package permission, which is not needed during CI.
There was a problem hiding this comment.
Added the env variable.
tests/ci/cdk/README.md
Outdated
| ``` | ||
| ./run-cdk.sh 123456789 us-west-2 GitHubUserName aws-lc SYNTH | ||
| ./run-cdk.sh --action build-img --github-access-token 123456 |
There was a problem hiding this comment.
Added the env variable.
| export S3_FOR_WIN_DOCKER_IMG_BUILD="${AWS_LC_S3_BUCKET_PREFIX}-${DATE_NOW}" | ||
| export WIN_EC2_TAG_KEY="aws-lc" | ||
| export WIN_EC2_TAG_KEY='aws-lc' |
There was a problem hiding this comment.
Why did we change this to single quotes? Was this being interpreted weirdly?
There was a problem hiding this comment.
No, the change is to use double quotes on demand.
* Pre-pull aws crt Docker images. * Remove unused code. * Run pull_github_pkg.sh in CodeBuild. * Update files under 'generated-src' dir. * Pre-pull aws crt Docker images. (#102) * Pre-pull aws crt Docker images. * Remove unused code. * Address comments. * Move common source. * Integrate pull script with CDK. (#103) * Pre-pull aws crt Docker images. * Remove unused code. * Run pull_github_pkg.sh in CodeBuild. * Address comments. * Move common source. * Change README.md * Address comments. * Build and test without Perl/Go. (#107) * Build and test without Perl/Go. * Revert 'delete update-webhook cli' * Fix typo. * Adds build flavor -DBUILD_TESTING=0 -DBUILD_SSL=0. * Adds build flavor -DBUILD_TESTING=0 -DBUILD_SSL=0 with release mode. * Fix typo. * Remove 'AWS_LC' prefix. * Fix build flag. * Add note. * Remove build with -DBUILD_TESTING=0 -DBUILD_SSL=0. * Remove build flags - BUILD_WITHOUT_GO and BUILD_WITHOUT_PERL..
Issues:
Addresses CryptoAlg-663
Description of changes:
This PR integrated the script created in #102 with CDK code.
aws ecr.run-cdk.shscript, arguments parser are refactored.Call-outs:
No support.Testing:
See log in
CryptoAlg-663?selectedConversation=33d3e3af-a5b5-4e5d-b78f-b4f49b8e250aBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.