Deprecated filter methods #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed issue with OD pricing for european regions (aws#132)
main into sorting
snay2
reviewed
Jun 24, 2022
pkg/selector/selector.go
Outdated
| @@ -132,6 +132,8 @@ func (itf Selector) Save() error { | |||
|
|
|||
| // Filter accepts a Filters struct which is used to select the available instance types | |||
| // matching the criteria within Filters and returns a simple list of instance type strings | |||
| // | |||
| // Deprecated: This function will no longer exist in the next major version. | |||
There was a problem hiding this comment.
If you know the names of the functions that will replace this in the next version, that would be useful information to include, in order to give consumers of the library guidance on what to expect.
There was a problem hiding this comment.
Good idea! I have added the names of the appropriate replacement functions in the deprecated comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: none
Description of changes:
In accordance with plans to modify the way in which users interface with the selector, the current
Filter(),FilterVerbose(), andFilterWithOutput()functions found inselector.gohave been labeled as "Deprecated."In the next major version of Instance-Selector, they will be replaced with new functions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.