fixed issue with OD pricing for european regions #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AustinSiu
reviewed
Jun 15, 2022
digocorbellini
added a commit
to digocorbellini/amazon-ec2-instance-selector
that referenced
this pull request
Jun 16, 2022
fixed issue with OD pricing for european regions (aws#132)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #131
Description of changes:
getRegionForPricingAPI() (found in odpricing.go on line 206) was returning the wrong region description for all European regions. It was returning descriptions with the word "Europe" instead of "Eu," which was causing the pricing API (called on line 170) to be unable to fetch on demand pricing for European regions.
I manually tested all region IDs and this formatting mismatch only seemed to occur with European regions, so to fix this issue, I used strings.Replace() to replace all mentions of "Europe" with "Eu" after the endpoint sdk found the correct region description based on the user's desired region ID.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.