Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated filter methods #133

Merged
merged 11 commits into from
Jun 27, 2022
Merged

Deprecated filter methods #133

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
59ae92b
fixed issue with OD pricing for european regions
Jun 14, 2022
f704d38
made string replacement more readable in getRegionForPricingAPI
Jun 15, 2022
b19f085
implemented sorting of instance types
Jun 16, 2022
98cda76
Merge pull request #1 from aws/main
digocorbellini Jun 16, 2022
ed1d702
Merge pull request #3 from digocorbellini/main
digocorbellini Jun 16, 2022
eb53d76
fixed typo in filtering error message
Jun 16, 2022
94749fd
moved sort to selector.go and refactored FilterVerbose tests
Jun 20, 2022
0edb169
brought back FilterWithOutput() in selector.go
Jun 20, 2022
d0a6e4c
working implementation of refactoring solution
Jun 23, 2022
d0cbd21
Deprecated the filter methods in selector.go
Jun 24, 2022
ac511dd
added the names of replacement functions to deprecated comments
Jun 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pkg/selector/selector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,9 @@ func (itf Selector) Save() error {

// Filter accepts a Filters struct which is used to select the available instance types
// matching the criteria within Filters and returns a simple list of instance type strings
//
// Deprecated: This function will be replaced with GetFilteredInstanceTypes() and
// OutputInstanceTypes() in the next major version.
func (itf Selector) Filter(filters Filters) ([]string, error) {
outputFn := InstanceTypesOutputFn(outputs.SimpleInstanceTypeOutput)
output, _, err := itf.FilterWithOutput(filters, outputFn)
Expand All @@ -140,6 +143,9 @@ func (itf Selector) Filter(filters Filters) ([]string, error) {

// FilterVerbose accepts a Filters struct which is used to select the available instance types
// matching the criteria within Filters and returns a list instanceTypeInfo
//
// Deprecated: This function will be replaced with GetFilteredInstanceTypes() in the next
// major version.
func (itf Selector) FilterVerbose(filters Filters) ([]*instancetypes.Details, error) {
instanceTypeInfoSlice, err := itf.rawFilter(filters)
if err != nil {
Expand All @@ -151,6 +157,9 @@ func (itf Selector) FilterVerbose(filters Filters) ([]*instancetypes.Details, er

// FilterWithOutput accepts a Filters struct which is used to select the available instance types
// matching the criteria within Filters and returns a list of strings based on the custom outputFn
//
// Deprecated: This function will be replaced with GetFilteredInstanceTypes() and
// OutputInstanceTypes() in the next major version.
func (itf Selector) FilterWithOutput(filters Filters, outputFn InstanceTypesOutput) ([]string, int, error) {
instanceTypeInfoSlice, err := itf.rawFilter(filters)
if err != nil {
Expand Down