-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tracer support for async, escape hatch, and patch given modules #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks good but I have questions regarding whether the tracer implementation is not too specific to X-Ray.
I dropped additional provider feature. Instead, this PR now tackles enhancements for |
Thank you once again @nmoutschen for the review :) It's now published in 0.9.0 |
* develop: Bugfix: "per second" metric units (#27)
* develop: (21 commits) bugfix: #32 Runtime Error for nested sync fns chore: renamed history to changelog dependabot bugfix: resolves #31 aiohttp lazy import chore: grammar issues improv: add project tenets Improv tracer - async support, patch, test coverage and X-Ray escape hatch (#29) Bugfix: "per second" metric units (#27) fix: #24 correct example test and docs chore: bump example to use 0.8.0 features Adopt logging best practices (#23) Decorator factory Feat: Create your own middleware (#17) chore: clean up CI workflows fix: CI attempt 4 fix: CI attempt 3 fix: CI attempt 3 fix: CI attempt 2 feat: add docs to CI chore: fix github badge typo chore: pypi monthly download badge fix: add missing single_metric example; test var name ...
…hatch (#29) * feat: use new TraceProvider * improv: update tests * improv: update docs, linting * improv: docstring readability and links * improv: remove tracer provider * fix: patch modules type * improv: use client ctx_manager for race conditions * improv: make disabling provider private again * chore: linting * fix: race condition annotation/metadata * chore: linting * feat: add async support for methods * improv: document async use cases, and edge cases * improv: upgrade xray, flex pinning * chore: linting * improv: update example for async, escape hatch * fix: add example dev deps in project * improv: add patch_modules example, formatting * improv: break down concurrent async calls example * docs: main doc clean up * docs: document async, escape hatch usage * chore: lint * docs: update example SAM template comments * chore: updates poetry lock file * improv: example to use py 3.8 * fix: AsyncMockMixin not being awaitable in 3.8 * fix: 3.8 defaulting to AsyncMock * improv: include x-ray bug for concurrent async calls * fix: address nicolas's feedback * improv: add security baseline as part of PR process * improv: enforce lower code complexity * chore: whitespace * improv: add complexity baseline * chore: bump version to 0.9.0 * chore: clean up history changes Co-authored-by: heitorlessa <[email protected]>
Issue #, if available: #28, #11, #10
Description of changes:
subsegment
entity/type (put_annotation, etc.)current_subsegment -> subsegment
UX for async
Customer needs to control the loop and await all coroutines
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.