Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: metrics "per second" metric units #27

Merged
merged 6 commits into from
May 1, 2020
Merged

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented May 1, 2020

Issue #, if available: #26

Description of changes:

  • Test for all possible metric unit values
  • Fix MetricUnit enum "per second" units

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@heitorlessa heitorlessa added the bug Something isn't working label May 1, 2020
@heitorlessa heitorlessa self-assigned this May 1, 2020
@heitorlessa heitorlessa changed the title [WIP] Fix per second metric units Bug: Fix per second metric units May 1, 2020
@heitorlessa heitorlessa changed the title Bug: Fix per second metric units Bugfix: "per second" metric units May 1, 2020
@heitorlessa heitorlessa merged commit 70d9277 into develop May 1, 2020
heitorlessa added a commit that referenced this pull request May 12, 2020
* develop:
  Bugfix: "per second" metric units (#27)
heitorlessa added a commit that referenced this pull request May 16, 2020
* develop: (21 commits)
  bugfix: #32 Runtime Error for nested sync fns
  chore: renamed history to changelog dependabot
  bugfix: resolves #31 aiohttp lazy import
  chore: grammar issues
  improv: add project tenets
  Improv tracer - async support, patch, test coverage and X-Ray escape hatch (#29)
  Bugfix: "per second" metric units (#27)
  fix: #24 correct example test and docs
  chore: bump example to use 0.8.0 features
  Adopt logging best practices (#23)
  Decorator factory Feat: Create your own middleware (#17)
  chore: clean up CI workflows
  fix: CI attempt 4
  fix: CI attempt 3
  fix: CI attempt 3
  fix: CI attempt 2
  feat: add docs to CI
  chore: fix github badge typo
  chore: pypi monthly download badge
  fix: add missing single_metric example; test var name
  ...
@heitorlessa heitorlessa changed the title Bugfix: "per second" metric units bugfix: "per second" metric units Jun 3, 2020
@heitorlessa heitorlessa changed the title bugfix: "per second" metric units fix: metrics "per second" metric units Jun 3, 2020
@heitorlessa heitorlessa deleted the fix/metric_unit branch June 5, 2020 17:56
heitorlessa referenced this pull request in heitorlessa/aws-lambda-powertools-python Jun 17, 2020
* improv: test all metric units

* fix: correct MetricUnit model values

* fix: metric unit as string branch logic

* chore: refactor

* chore: test str

* chore: bump version with metric unit patch

Co-authored-by: heitorlessa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant