Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aiohttp is now a required dependency #31

Closed
michaelbrewer opened this issue May 14, 2020 · 8 comments
Closed

aiohttp is now a required dependency #31

michaelbrewer opened this issue May 14, 2020 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@michaelbrewer
Copy link
Contributor

Even if you don't use or require aiohttp, powertools now has it as a dependency. So now projects without this already declared will fail

/opt/python/3.7.6/lib/python3.7/site-packages/aws_lambda_powertools/tracing/__init__.py:3: in <module>
    from aws_xray_sdk.ext.aiohttp.client import aws_xray_trace_config as aiohttp_trace_config
/opt/python/3.7.6/lib/python3.7/site-packages/aws_xray_sdk/ext/aiohttp/client.py:4: in <module>
    import aiohttp
E   ModuleNotFoundError: No module named 'aiohttp'
@heitorlessa
Copy link
Contributor

heitorlessa commented May 14, 2020 via email

@heitorlessa
Copy link
Contributor

Publishing a fix in a few minutes

@michaelbrewer
Copy link
Contributor Author

Awesome thanks. Great tool.

FYI when using dependabot I don’t see any changelog coming through, maybe by v1 you can start generating one in the repo :)

@heitorlessa
Copy link
Contributor

Just published 0.9.2 with the bugfix - Wheels took a while to generate this time.

Ha! I thought it was picking up HISTORY file changes - I'll look into it, and thanks again for the tip ;)

Let me know if that works for you @michaelbrewer

@heitorlessa heitorlessa reopened this May 14, 2020
@heitorlessa heitorlessa self-assigned this May 14, 2020
@heitorlessa heitorlessa added the bug Something isn't working label May 14, 2020
@michaelbrewer
Copy link
Contributor Author

@heitorlessa yes, i think @dependabot is looking for a CHANGELOG.md file.

I can confirm that the fix is working again.

@heitorlessa
Copy link
Contributor

heitorlessa commented May 14, 2020 via email

@michaelbrewer
Copy link
Contributor Author

@heitorlessa completely unrelated, but you might want to setup GPG signing for your your commits to github.

@heitorlessa
Copy link
Contributor

heitorlessa commented May 14, 2020

In my backlog already :). Done, better sooner than postponing once again

heitorlessa added a commit that referenced this issue May 16, 2020
* develop: (21 commits)
  bugfix: #32 Runtime Error for nested sync fns
  chore: renamed history to changelog dependabot
  bugfix: resolves #31 aiohttp lazy import
  chore: grammar issues
  improv: add project tenets
  Improv tracer - async support, patch, test coverage and X-Ray escape hatch (#29)
  Bugfix: "per second" metric units (#27)
  fix: #24 correct example test and docs
  chore: bump example to use 0.8.0 features
  Adopt logging best practices (#23)
  Decorator factory Feat: Create your own middleware (#17)
  chore: clean up CI workflows
  fix: CI attempt 4
  fix: CI attempt 3
  fix: CI attempt 3
  fix: CI attempt 2
  feat: add docs to CI
  chore: fix github badge typo
  chore: pypi monthly download badge
  fix: add missing single_metric example; test var name
  ...
heitorlessa referenced this issue in heitorlessa/aws-lambda-powertools-python Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants