-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aiohttp is now a required dependency #31
Comments
Thanks for reporting Michael - Looking into this ASAP
…On Thu, 14 May 2020 at 15:01, Michael Brewer ***@***.***> wrote:
Even if you don't use or require aiohttp, powertools now has it as a
dependency. So now projects without this already declared will fail
/opt/python/3.7.6/lib/python3.7/site-packages/aws_lambda_powertools/tracing/__init__.py:3: in <module>
from aws_xray_sdk.ext.aiohttp.client import aws_xray_trace_config as aiohttp_trace_config
/opt/python/3.7.6/lib/python3.7/site-packages/aws_xray_sdk/ext/aiohttp/client.py:4: in <module>
import aiohttp
E ModuleNotFoundError: No module named 'aiohttp'
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<aws-powertools/powertools-lambda#31>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBH5PHJ7YVT6WKXR2NLRRP2URANCNFSM4NAW3HAA>
.
|
Publishing a fix in a few minutes |
Awesome thanks. Great tool. FYI when using dependabot I don’t see any changelog coming through, maybe by v1 you can start generating one in the repo :) |
Just published 0.9.2 with the bugfix - Wheels took a while to generate this time. Ha! I thought it was picking up HISTORY file changes - I'll look into it, and thanks again for the tip ;) Let me know if that works for you @michaelbrewer |
@heitorlessa yes, i think @dependabot is looking for a CHANGELOG.md file. I can confirm that the fix is working again. |
Awesome! Thanks again for the bug report
…On Thu, 14 May 2020 at 16:48, Michael Brewer ***@***.***> wrote:
Closed #31 <aws-powertools/powertools-lambda#31>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<aws-powertools/powertools-lambda#31 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBF4BXPSYX6LQ4I5AG3RRQHEVANCNFSM4NAW3HAA>
.
|
@heitorlessa completely unrelated, but you might want to setup GPG signing for your your commits to github. |
In my backlog already :). Done, better sooner than postponing once again |
* develop: (21 commits) bugfix: #32 Runtime Error for nested sync fns chore: renamed history to changelog dependabot bugfix: resolves #31 aiohttp lazy import chore: grammar issues improv: add project tenets Improv tracer - async support, patch, test coverage and X-Ray escape hatch (#29) Bugfix: "per second" metric units (#27) fix: #24 correct example test and docs chore: bump example to use 0.8.0 features Adopt logging best practices (#23) Decorator factory Feat: Create your own middleware (#17) chore: clean up CI workflows fix: CI attempt 4 fix: CI attempt 3 fix: CI attempt 3 fix: CI attempt 2 feat: add docs to CI chore: fix github badge typo chore: pypi monthly download badge fix: add missing single_metric example; test var name ...
Even if you don't use or require aiohttp, powertools now has it as a dependency. So now projects without this already declared will fail
The text was updated successfully, but these errors were encountered: