Move all dashboards to GitOps #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will need to remove provider in a separate version to provide a transition path as removing this will break terraform and leave orphans in the state
Standardize config objects for patterns as well
bonclay7
temporarily deployed
to
Observability Test
GitHub Actions
Inactive
…rafana * origin/fix/adot-restart: Pre-commit Avoid DDoS with using 0.0.0.0 Move external labels to resource attributes
bonclay7
temporarily deployed
to
Observability Test
GitHub Actions
Inactive
bonclay7
temporarily deployed
to
Observability Test
GitHub Actions
Inactive
bonclay7
temporarily deployed
to
Observability Test
GitHub Actions
Inactive
bonclay7
temporarily deployed
to
Observability Test
GitHub Actions
Inactive
bonclay7
temporarily deployed
to
Observability Test
GitHub Actions
Inactive
bonclay7
temporarily deployed
to
Observability Test
GitHub Actions
Inactive
bonclay7
temporarily deployed
to
Observability Test
GitHub Actions
Inactive
bonclay7
temporarily deployed
to
Observability Test
GitHub Actions
Inactive
elamaran11
reviewed
Jun 8, 2023
There was a problem hiding this comment.
@bonclay7 LGTM. This is lot of amazing work. We should test it a few times with e2e before merge.
bonclay7
temporarily deployed
to
Observability Test
GitHub Actions
Inactive
bonclay7
temporarily deployed
to
Observability Test
GitHub Actions
Inactive
* Fixing SSM * Fixing SSM * Replacing Secrets Manager with SSM * Replacing Secrets Manager with SSM
bonclay7
temporarily deployed
to
Observability Test
GitHub Actions
Inactive
bonclay7
temporarily deployed
to
Observability Test
GitHub Actions
Inactive
bonclay7
temporarily deployed
to
Observability Test
GitHub Actions
Inactive
bonclay7
temporarily deployed
to
Observability Test
GitHub Actions
Inactive
bonclay7
temporarily deployed
to
Observability Test
GitHub Actions
Inactive
…into cleanup/grafana * origin/feature/grafanaOperatorVersion: Fixing Grafana Operator Version
bonclay7
temporarily deployed
to
Observability Test
GitHub Actions
Inactive
bonclay7
temporarily deployed
to
Observability Test
GitHub Actions
Inactive
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Continuation of #164, linked to aws-observability/aws-observability-accelerator#5
This PR should be merged first.
summary of changes
release plan
These changes give the opportunity to remove the Terraform Grafana provider from all modules expect the
amp-monitoringwhich can be used without even using EKS (so no cluster to run grafana operator). This can greatly simplify multi-cluster and cross account/region scenarios.However, dropping the provider will cause a Terraform issue as it won't be able to cleanup resources created by Terraform in Grafana. The release plan will consist on having
v2.5.0-beta(with this PR) without the provider config but without the resources so Terraform remove dashboards and foldersv2.5.0(another PR) that do not have a grafana provider at all. Customer using the modules from scratch can directly use this version.We will write this migration plan in the release notes and docs
Next steps
More
pre-commit run -awith this PRNote: Not all the PRs required examples and docs.
For Moderators
Additional Notes