Setup dashboards for patterns (java, nginx) on EKS #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elamaran11
reviewed
Jun 5, 2023
There was a problem hiding this comment.
@bonclay7 I love the approach of adding nginx, java monitoring modules to the accelerator solution. We should have different design to align to separation of concerns. If you do what you have in this PR, everything gets deployed even if customer is looking for infra monitoring only. I recommend having separate kustomization resource for each individual monitoring needs like Java, nginx and move java and nginx manifests to seprate folder and have that render in the new Kustomization so we have separation of concerns and single responsibility principle. We can talk about it if you want. We can design it efficiently as a pattern for others to folllow.
9 tasks
bonclay7
changed the title
elamaran11
reviewed
Jun 7, 2023
artifacts/grafana-operator-manifests/eks/java/kustomization.yaml
Outdated
Show resolved
Hide resolved
artifacts/grafana-operator-manifests/eks/nginx/kustomization.yaml
Outdated
Show resolved
Hide resolved
elamaran11
reviewed
Jun 7, 2023
artifacts/grafana-operator-manifests/amp/amg_grafana-cw-datasource.yaml
Outdated
Show resolved
Hide resolved
The operator seems to only take into account the dashboards listed in the eks infrastructure identity. This is an attempt to create a separate identity for the nginx pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.