Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Grafana provider for EKS #179

Merged
merged 3 commits into from
Jun 12, 2023
Merged

Remove Grafana provider for EKS #179

merged 3 commits into from
Jun 12, 2023

Conversation

bonclay7
Copy link
Member

What does this PR do?

Cleaning Grafana provider following up on #175

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR
  • Yes, I have added a new example under examples to support my PR (when applicable)
  • Yes, I have updated the Pages for this feature

Note: Not all the PRs required examples and docs.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bonclay7 bonclay7 temporarily deployed to Observability Test June 12, 2023 17:38 — with GitHub Actions Inactive
lewinkedrs
lewinkedrs approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@lewinkedrs lewinkedrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@bonclay7 bonclay7 merged commit 86d0831 into main Jun 12, 2023
@bonclay7 bonclay7 deleted the cleanup/grafana-provider branch June 12, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewinkedrs lewinkedrs lewinkedrs approved these changes

@awsimaya awsimaya Awaiting requested review from awsimaya

@elamaran11 elamaran11 Awaiting requested review from elamaran11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bonclay7 @lewinkedrs