Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope down unnecessary permissions #49

Merged
merged 12 commits into from
Apr 19, 2024

Conversation

Almenon
Copy link
Contributor

@Almenon Almenon commented Feb 19, 2024

What does this PR do?

  • Tightens permissions for better security

Motivation

My workplace pays me to do devops, and I can use that money to buy donuts. On a more specific level, these changes are needed for our security requirements at iSpot.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Same as #23, re-opened from different branch so there is no merge conflicts.

@Almenon Almenon requested review from vara-bonthu and a team as code owners February 19, 2024 18:41
@Almenon Almenon mentioned this pull request Feb 19, 2024
3 tasks
Copy link
Collaborator

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please confirm if these changes are tested. 🙏

@vara-bonthu vara-bonthu merged commit 9337294 into aws-ia:main Apr 19, 2024
@Almenon
Copy link
Contributor Author

Almenon commented Apr 21, 2024

Yeah, these changes were tested. Thanks for the merge!

@Almenon Almenon deleted the permission-changes branch April 21, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants