Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope down unnecessary permissions #49

Merged
merged 12 commits into from
Apr 19, 2024
+8 −4
Merged

Scope down unnecessary permissions #49

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f294fe5
change requirements
Almenon Jan 19, 2023
d2a452b
restrict permissions to be more secure
Almenon Jan 27, 2023
14e99fa
uncomment
Almenon Jan 28, 2023
f78fdb4
make prefix a bit more explicit
Almenon Jan 28, 2023
fdf8e55
fix whitespace
Almenon Mar 19, 2023
18e0c91
update docs
Almenon Mar 19, 2023
a409297
Merge branch 'main' into main
Almenon Apr 6, 2023
483d3be
remove secretmanager access
Almenon May 11, 2023
a4e97d8
remove secretmanager access
Almenon May 11, 2023
8bd4cc4
remove secret prefix
Almenon May 11, 2023
dac12d5
Merge branch 'aws-ia:main' into main
Almenon Jun 27, 2023
5c4ffd3
Merge branch 'main' into permission-changes
Almenon Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions data.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ data "aws_iam_policy_document" "mwaa" {
statement {
effect = "Allow"
actions = [
"s3:*"
"s3:GetObject*",
"s3:GetBucket*",
"s3:List*"
]
resources = [
local.source_bucket_arn,
Expand Down Expand Up @@ -84,9 +86,7 @@ data "aws_iam_policy_document" "mwaa" {
actions = [
"logs:DescribeLogGroups",
"cloudwatch:PutMetricData",
"batch:DescribeJobs",
"batch:ListJobs",
"eks:*"
"s3:GetAccountPublicAccessBlock"
]
resources = [
"*"
Expand All @@ -108,6 +108,10 @@ data "aws_iam_policy_document" "mwaa" {
]
}

# See note in https://docs.aws.amazon.com/mwaa/latest/userguide/mwaa-create-role.html
# if MWAA is using a AWS managed KMS key, we have to give permission to the key in ?? account
# We don't know what account AWS puts their key in so we use not_resources to grant access to all
# accounts except for ours
dynamic "statement" {
for_each = var.kms_key != null ? [] : [1]
content {
Expand Down