-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scope down unnecessary permissions #23
Conversation
@Almenon thank you for the PR. Can you please open separate out the PR for version pinning, secrets, and scoped down permissions? Also please create issues for the secret and permissions so we can examine it closely. |
@Almenon thanks for creating the issues. Would you mind splitting the PR? One for TF versions and other one for permissions? We will merge the versions ASAP and investigate the permissions after. Thanks 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @Almenon ! Left few comments needs addressing other than that we are good to go.
One can use iam_role_additional_policies instead
one can use iam_role_additional_policies instead
no longer needed
@vara-bonthu done, and good point. Thanks. |
@vara-bonthu following up on this, good to merge? |
@Almenon Sorry for the delay. We are planning to test this feature and include this as a part of any upgrades required. I will merge it once its tested |
Adding ability to add additional principal to trusted policy
@vara-bonthu any updates on this? It's important to have the reduced permissions. @Almenon any interest in updating this PR to resolve the branch conflicts? if not, I'm happy to port over these changes to a new pr that is up to date with the main branch |
Updated. I opened a new PR with conflicts resolved. See #49 |
What does this PR do?
secret_prefix
var one can use to grant MWAA access to secrets under a certain prefix.Motivation
My workplace pays me to do devops, and I can use that money to buy donuts. On a more specific level, these changes are needed for our security requirements at iSpot. The version pinning is needed to avoid conflicts.
More
pre-commit run -a
with this PRFor Moderators
Additional Notes