Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Blueprint for VPC lattice with kubernetes api controllers #1830

Closed
wants to merge 12 commits into from

Conversation

neelaruban
Copy link

@neelaruban neelaruban commented Nov 16, 2023

Description

Provisioning VPC Lattice and use the API gateway controller to connect services across EKS clusters

Motivation and Context

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Additional Notes

@neelaruban neelaruban requested a review from a team as a code owner November 16, 2023 06:12
@neelaruban neelaruban force-pushed the blueprint-vpc-lattice branch from 8f02aa0 to fcf260d Compare November 16, 2023 06:42
@neelaruban neelaruban changed the title blueprint for VPC lattice with kubernetes api controllers feat: blueprint for VPC lattice with kubernetes api controllers Nov 16, 2023
@neelaruban neelaruban changed the title feat: blueprint for VPC lattice with kubernetes api controllers feat: Blueprint for VPC lattice with kubernetes api controllers Nov 16, 2023
Copy link
Contributor

@allamand allamand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There is no version engine defined for the RDS module, it does not deploy.
  • Does RDS is needed for this pattern ? seems we can simplify by having simpler deployment
  • you should have output.tf so that users can connect to the cluster by executing the output (see others patterns for reference)

patterns/blueprint-vpc-lattice/README.md Outdated Show resolved Hide resolved
patterns/blueprint-vpc-lattice/cluster1/main.tf Outdated Show resolved Hide resolved
patterns/blueprint-vpc-lattice/cluster2/secrets.sh Outdated Show resolved Hide resolved
patterns/blueprint-vpc-lattice/cluster2/secrets.sh Outdated Show resolved Hide resolved
patterns/blueprint-vpc-lattice/cluster2/aurora.tf Outdated Show resolved Hide resolved
patterns/blueprint-vpc-lattice/README.md Outdated Show resolved Hide resolved
patterns/blueprint-vpc-lattice/README.md Outdated Show resolved Hide resolved
patterns/blueprint-vpc-lattice/README.md Outdated Show resolved Hide resolved
patterns/blueprint-vpc-lattice/README.md Show resolved Hide resolved
@allamand
Copy link
Contributor

Thanks for updated, is it working on your side ? My targets groups are not able to join the pods on my side

patterns/blueprint-vpc-lattice/README.md Outdated Show resolved Hide resolved
patterns/blueprint-vpc-lattice/README.md Outdated Show resolved Hide resolved
patterns/blueprint-vpc-lattice/README.md Outdated Show resolved Hide resolved
@@ -0,0 +1,6 @@
## Setting up PostgreSQL database
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets remove all of the database dependencies unless there is a strong reason why this needs to be included in the pattern

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got this idea from a blog post that's already linked to this problem/request which depends upon the aurora RDS .
https://aws.amazon.com/blogs/containers/application-networking-with-amazon-vpc-lattice-and-amazon-eks/

i am happy to work on a different scenario if you could direct me in the right direction

patterns/blueprint-vpc-lattice/cluster1/main.tf Outdated Show resolved Hide resolved
patterns/blueprint-vpc-lattice/cluster1/main.tf Outdated Show resolved Hide resolved
patterns/blueprint-vpc-lattice/cluster1/main.tf Outdated Show resolved Hide resolved
patterns/blueprint-vpc-lattice/cluster1/main.tf Outdated Show resolved Hide resolved
patterns/blueprint-vpc-lattice/cluster1/main.tf Outdated Show resolved Hide resolved
patterns/blueprint-vpc-lattice/cluster1/outputs.tf Outdated Show resolved Hide resolved
@neelaruban
Copy link
Author

Thanks for updated, is it working on your side ? My targets groups are not able to join the pods on my side

let me test it again

@neelaruban
Copy link
Author

As it turns out the current version of EKS blueprint addon needs extra permissions for the aws gateway api controller to create httproutes , i have already issued a PR to fix it
could someone please look into it , thanks
tracked issue

@neelaruban
Copy link
Author

@allamand @bryantbiggs I have introduced new workloads for the VPC lattice patterns with the gateway API controllers, Could you please review them :D

Copy link
Contributor

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Jan 12, 2024
@neelaruban
Copy link
Author

@allamand please let me know if my latest changes are sufficient to merge this PR , thanks

@github-actions github-actions bot removed the stale label Jan 13, 2024
@allamand
Copy link
Contributor

@neelaruban rhere was an issue with VPC lattice controller v1.0.2 which prevented service import to work properly. This is now fixed in latest release v1.0.3. In the meantime we actually have 2 PRs for lattice. We are working to have different use cases in same pattern starting with the other one which is simpler. In my opinion the real value will be to focus on cross cluster flows with TLS encryption and IAM authorizations.

What I suggest would be to adapt your actual pattern to be a use-case dedicated to microservices flows sécurisation. (Merge the code as new use case in the other VPC lattice pattern, and add examples for iam auth). I can help with this

Copy link
Contributor

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Feb 21, 2024
Copy link
Contributor

github-actions bot commented Mar 3, 2024

Pull request closed due to inactivity.

@github-actions github-actions bot closed this Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Gateway Controller add-on to update cluster SG Blueprint for VPC Lattice
4 participants