-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Blueprint for VPC lattice with kubernetes api controllers #1830
Conversation
8f02aa0
to
fcf260d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- There is no version engine defined for the RDS module, it does not deploy.
- Does RDS is needed for this pattern ? seems we can simplify by having simpler deployment
- you should have output.tf so that users can connect to the cluster by executing the output (see others patterns for reference)
Thanks for updated, is it working on your side ? My targets groups are not able to join the pods on my side |
@@ -0,0 +1,6 @@ | |||
## Setting up PostgreSQL database |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets remove all of the database dependencies unless there is a strong reason why this needs to be included in the pattern
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got this idea from a blog post that's already linked to this problem/request which depends upon the aurora RDS .
https://aws.amazon.com/blogs/containers/application-networking-with-amazon-vpc-lattice-and-amazon-eks/
i am happy to work on a different scenario if you could direct me in the right direction
let me test it again |
As it turns out the current version of EKS blueprint addon needs extra permissions for the aws gateway api controller to create httproutes , i have already issued a PR to fix it |
@allamand @bryantbiggs I have introduced new workloads for the VPC lattice patterns with the gateway API controllers, Could you please review them :D |
This PR has been automatically marked as stale because it has been open 30 days |
@allamand please let me know if my latest changes are sufficient to merge this PR , thanks |
@neelaruban rhere was an issue with VPC lattice controller v1.0.2 which prevented service import to work properly. This is now fixed in latest release v1.0.3. In the meantime we actually have 2 PRs for lattice. We are working to have different use cases in same pattern starting with the other one which is simpler. In my opinion the real value will be to focus on cross cluster flows with TLS encryption and IAM authorizations. What I suggest would be to adapt your actual pattern to be a use-case dedicated to microservices flows sécurisation. (Merge the code as new use case in the other VPC lattice pattern, and add examples for iam auth). I can help with this |
This PR has been automatically marked as stale because it has been open 30 days |
Pull request closed due to inactivity. |
Description
Provisioning VPC Lattice and use the API gateway controller to connect services across EKS clusters
Motivation and Context
How was this change tested?
pre-commit run -a
with this PRAdditional Notes