Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add pattern for Amazon VPC Lattice #1846

Merged
merged 28 commits into from
Jan 23, 2024
Merged

feat: Add pattern for Amazon VPC Lattice #1846

merged 28 commits into from
Jan 23, 2024

Conversation

valentinwidmer
Copy link
Contributor

Description

Motivation and Context

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Additional Notes

@valentinwidmer valentinwidmer requested a review from a team as a code owner December 14, 2023 10:54
@valentinwidmer valentinwidmer changed the title Add example for Amazon VPC Lattice feat: Add pattern for Amazon VPC Lattice Dec 14, 2023
rodrigobersa
rodrigobersa requested changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@rodrigobersa rodrigobersa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @valentinwidmer! Looks awesome!
A few comments.

Run the pre-commit to fix the end of a few files.

patterns/vpc-lattice/assets/server-response.jpeg Outdated Show resolved Hide resolved
patterns/aws-vpc-cni-network-policy/main.tf Outdated Show resolved Hide resolved
patterns/vpc-lattice/main.tf Outdated Show resolved Hide resolved
patterns/vpc-lattice/main.tf Outdated Show resolved Hide resolved
patterns/vpc-lattice/main.tf Outdated Show resolved Hide resolved
patterns/vpc-lattice/main.tf Outdated Show resolved Hide resolved
rodrigobersa
rodrigobersa requested changes Dec 20, 2023
View reviewed changes
patterns/aws-vpc-cni-network-policy/versions.tf Outdated Show resolved Hide resolved
patterns/vpc-lattice/main.tf Outdated Show resolved Hide resolved
@allamand
Copy link
Contributor

There was already a PR for this, did you saw it before opening this one ? #1830

@valentinwidmer
Copy link
Contributor Author

There was already a PR for this, did you saw it before opening this one ? #1830

There was an internal alignment to work on this feature. Please reach out internally for questions.

allamand
allamand reviewed Jan 15, 2024
View reviewed changes
Copy link
Contributor

@allamand allamand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've put some conmments, and improve it with external-dns integration. Would like to see with you how to merge this

patterns/vpc-lattice/README.md Outdated Show resolved Hide resolved
patterns/vpc-lattice/README.md Outdated Show resolved Hide resolved
patterns/vpc-lattice/main.tf Outdated Show resolved Hide resolved
dependabot bot and others added 9 commits January 16, 2024 10:38
@dependabot
chore(deps): Bump github/codeql-action from 3.22.11 to 3.22.12 (aws-i…
fc1bd85 
…a#1850)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): Bump actions/dependency-review-action from 3.1.4 to 3.1.5 (
be46054 
aws-ia#1854)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): Bump github/codeql-action from 3.22.12 to 3.23.0 (aws-ia…
71e838e 
…#1855)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): Bump actions/upload-artifact from 4.0.0 to 4.1.0 (aws-ia…
fb7305b 
…#1857)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@allamand
fix: Change image path in blue/green pattern (aws-ia#1856)
cbd827c
Minor fixes and improvements
6486035
Re-run pre-commit hooks
90deace
@allamand
using external-dns to create DNS records
afb29ae
Re-run pre-commit
a6a4c42
@valentinwidmer
Copy link
Contributor Author

I've put some conmments, and improve it with external-dns integration. Would like to see with you how to merge this

As discussed, I've merged the external-dns changes into this branch

allamand
allamand approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@allamand allamand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks. We can now add additional uses cases for vpc lattice

rodrigobersa
rodrigobersa requested changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@rodrigobersa rodrigobersa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments, the rest is great!

patterns/vpc-lattice/README.md Outdated Show resolved Hide resolved
patterns/vpc-lattice/01_client-server-communication/main.tf Outdated Show resolved Hide resolved
rodrigobersa
rodrigobersa approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@rodrigobersa rodrigobersa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @valentinwidmer

@rodrigobersa rodrigobersa merged commit b71c100 into aws-ia:main Jan 23, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigobersa rodrigobersa rodrigobersa approved these changes

@allamand allamand allamand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blueprint for VPC Lattice
3 participants
@valentinwidmer @allamand @rodrigobersa