Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Api controller addon upgrade v1.0.1 #331

Closed

Conversation

neelaruban
Copy link
Contributor

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@neelaruban neelaruban requested a review from a team as a code owner December 12, 2023 05:09
@neelaruban neelaruban changed the title Api controller addon upgrade v1.0.1 fix: Api controller addon upgrade v1.0.1 Dec 12, 2023
@bryantbiggs
Copy link
Contributor

how has this been validated, are there any schema changes for the chart?

@neelaruban
Copy link
Contributor Author

how has this been validated, are there any schema changes for the chart?

there are no schema changes for the chart - they have introduced a new environment variable which can be provided via set values .

Added DEFAULT_SERVICE_NETWORK environment variable that will automatically create a service network and its VPC association at the controller startup #502

apart from that the new version of the chart requires additional policies which are breaking changes

Breaking Changes
IAM Policies

The required IAM policies have changed - tag:GetResources policy is now required for running the controller. Please update your existing service account with the new policy provided in examples/recommended-inline-policy.json.
Gateway/VPCAssociationPolicy

Creating a Gateway no longer creates a service network and its VPC association. Please refer to the documentation for more details. Existing service networks and their associations will not be deleted.
Deprecated Gateway’s application-networking.k8s.aws/lattice-vpc-association annotation. Instead, use VPCAssociationPolicy CRD to configure an association.
Added ownership concept to VPCAssociationPolicy. It will no longer delete VPC associations that are not owned by the controller.

@allamand
Copy link
Contributor

the v1.0.2 is already out with some fixes

Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Jan 21, 2024
Copy link

github-actions bot commented Feb 1, 2024

Pull request closed due to inactivity.

@github-actions github-actions bot closed this Feb 1, 2024
@askulkarni2 askulkarni2 removed the stale label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Gateway Controller add-on upgrade to v1.0.0
5 participants