Provide default gateway setup #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you update doc and add instruction says that we need to pass DEFAULT_SERVICE_NETWORK to start the controller when run the Overall LGTM. |
zijun726911
reviewed
Nov 15, 2023
docs/configure/environment.md
Outdated
|
|
||
| --- | ||
|
|
||
| #### `TARGET_GROUP_NAME_LEN_MODE` | ||
| #### `ENABLE_NETWORK_OVERRIDE` |
There was a problem hiding this comment.
That can be a better name: ENABLE_SERVICE_NETWORK_OVERRIDE ?
zijun726911
reviewed
Nov 15, 2023
| if err != nil { | ||
| return fmt.Errorf("%w: failed to delete service network %s due to %s", RetryErr, snName, resp) | ||
| if snva != nil { | ||
| m.log.Debugf("ServiceNetwork %s also has VPC association %s", serviceNetwork.Spec.Name, snva.Arn) |
There was a problem hiding this comment.
should be: ServiceNetwork %s already has VPC association ?
|
Addressed the comments, thanks |
zijun726911
approved these changes
Nov 15, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
Testing done on this change:
Automation added to e2e:
Will this PR introduce any new dependencies?:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.