Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map_based_prediction): use acc for map prediction #788

Conversation

danielsanchezaran
Copy link
Contributor

Description

Required by autowarefoundation/autoware.universe#6072

Related links

autowarefoundation/autoware.universe#6072

Tests performed

See autowarefoundation/autoware.universe#6072

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

danielsanchezaran and others added 4 commits January 16, 2024 09:40
Signed-off-by: Daniel Sanchez <[email protected]>
Signed-off-by: Daniel Sanchez <[email protected]>
@danielsanchezaran danielsanchezaran force-pushed the feat/use-acc-for-map-prediction branch from bb63fd0 to 276fede Compare January 16, 2024 01:00
@danielsanchezaran danielsanchezaran merged commit 61d8ee5 into autowarefoundation:main Jan 19, 2024
8 of 10 checks passed
@danielsanchezaran danielsanchezaran deleted the feat/use-acc-for-map-prediction branch January 19, 2024 04:16
zulfaqar-azmi-t4 pushed a commit to tier4/autoware_launch that referenced this pull request Mar 7, 2024
…ation#788)

* add param to toggle on and off acc consideration

Signed-off-by: Daniel Sanchez <[email protected]>

* add params

Signed-off-by: Daniel Sanchez <[email protected]>

* set default to true for evaluator testing

Signed-off-by: Daniel Sanchez <[email protected]>

* set back to false default

Signed-off-by: Daniel Sanchez <[email protected]>

---------

Signed-off-by: Daniel Sanchez <[email protected]>
Signed-off-by: Daniel Sanchez <[email protected]>
zulfaqar-azmi-t4 pushed a commit to tier4/autoware_launch that referenced this pull request Mar 7, 2024
t4-adc pushed a commit to tier4/autoware_launch that referenced this pull request Mar 21, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 13, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 13, 2024
yuki-takagi-66 pushed a commit to tier4/autoware_launch that referenced this pull request Jul 3, 2024
technolojin pushed a commit to technolojin/autoware_launch that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants