Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_system_launch): add autoware prefix to dummy diag publisher launcher #9959

Conversation

TetsuKawa
Copy link
Contributor

@TetsuKawa TetsuKawa commented Jan 18, 2025

Description

This PR replace dummy_diag_publisher to autoware_diag_publisher.

Related links

Other PR

How was this PR tested?

https://github.com/TetsuKawa/autoware.universe/tree/test/add-autoware-prefix-to-dummy-diag-publisher , which merged this branch and #9946, was testd.

  1. $ ros2 launch autoware_launch planning_simulator.launch.xml map_path:=$HOME/autoware_map/sample-map-planning vehicle_model:=sample_vehicle sensor_model:=sample_sensor_kit
  2. ros2 node list | grep dummy_diag_publisher
  3. $ ros2 param set /dummy_diag_publisher "topic_state_monitor_pointcloud_map: map_topic_status".is_active true or false
  4. $ ros2 param set /dummy_diag_publisher "topic_state_monitor_pointcloud_map: map_topic_status".status "Error", Warn or OK
Screencast.from.2025.01.18.15.51.25.webm

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@TetsuKawa TetsuKawa self-assigned this Jan 18, 2025
@github-actions github-actions bot added component:system System design and integration. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jan 18, 2025
Copy link

github-actions bot commented Jan 18, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@TetsuKawa TetsuKawa added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test run:clang-tidy-pr-review and removed component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jan 18, 2025
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 29.12%. Comparing base (67ab350) to head (0f1697f).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
...y_diag_publisher/src/dummy_diag_publisher_core.cpp 0.00% 29 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9959      +/-   ##
==========================================
- Coverage   29.13%   29.12%   -0.01%     
==========================================
  Files        1425     1425              
  Lines      107853   107821      -32     
  Branches    42251    42235      -16     
==========================================
- Hits        31419    31400      -19     
+ Misses      73391    73380      -11     
+ Partials     3043     3041       -2     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 29.13% <ø> (-0.01%) ⬇️ Carriedforward from e141641

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Jan 18, 2025
@TetsuKawa TetsuKawa force-pushed the fix/add-autoware-prefix-to-dummy-diag-publisher-launcher branch from 0f1697f to aee4eb8 Compare January 20, 2025 05:50
@github-actions github-actions bot removed the component:system System design and integration. (auto-assigned) label Jan 20, 2025
@TetsuKawa TetsuKawa marked this pull request as ready for review January 20, 2025 05:53
@TetsuKawa TetsuKawa requested a review from ito-san as a code owner January 20, 2025 05:53
Copy link
Contributor

@sasakisasaki sasakisasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick Comment

👍

Reason for Approval

I believe this PR is related to this one. So I understand this PR is the fix for calling the fixed package (autoware_dummy_diag_publisher) via tier4_system_launch.

If this my understanding is correct, we can merge this PR 👍. Thanks!

(EDITED): It is better to merge this PR first before merging this PR

Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TetsuKawa TetsuKawa merged commit 374316b into autowarefoundation:main Jan 22, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:clang-tidy-pr-review tag:require-cuda-build-and-test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants