-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tier4_system_launch): add autoware prefix to dummy diag publisher launcher #9959
fix(tier4_system_launch): add autoware prefix to dummy diag publisher launcher #9959
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9959 +/- ##
==========================================
- Coverage 29.13% 29.12% -0.01%
==========================================
Files 1425 1425
Lines 107853 107821 -32
Branches 42251 42235 -16
==========================================
- Hits 31419 31400 -19
+ Misses 73391 73380 -11
+ Partials 3043 3041 -2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: TetsuKawa <[email protected]>
0f1697f
to
aee4eb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick Comment
👍
Reason for Approval
I believe this PR is related to this one. So I understand this PR is the fix for calling the fixed package (autoware_dummy_diag_publisher
) via tier4_system_launch
.
If this my understanding is correct, we can merge this PR 👍. Thanks!
(EDITED): It is better to merge this PR first before merging this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR replace dummy_diag_publisher to autoware_diag_publisher.
Related links
Other PR
How was this PR tested?
https://github.com/TetsuKawa/autoware.universe/tree/test/add-autoware-prefix-to-dummy-diag-publisher , which merged this branch and #9946, was testd.
$ ros2 launch autoware_launch planning_simulator.launch.xml map_path:=$HOME/autoware_map/sample-map-planning vehicle_model:=sample_vehicle sensor_model:=sample_sensor_kit
$ ros2 param set /dummy_diag_publisher "topic_state_monitor_pointcloud_map: map_topic_status".is_active true
orfalse
$ ros2 param set /dummy_diag_publisher "topic_state_monitor_pointcloud_map: map_topic_status".status "Error"
,Warn
orOK
Screencast.from.2025.01.18.15.51.25.webm
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.