Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_dummy_diag_publisher): add autowre prefix #9958

Conversation

TetsuKawa
Copy link
Contributor

@TetsuKawa TetsuKawa commented Jan 18, 2025

Description

This PR changes package name to atuoware_dummy_diag_publisher

Related links

Private Links:

these PR is necessary to be merged with this PR.

How was this PR tested?

  1. ros2 launch autoware_dummy_diag_publisher dummy_diag_publisher.launch.xml
  2. $ ros2 param set /dummy_diag_publisher dummy_diag_empty.is_active true or false
  3. $ ros2 param set /dummy_diag_publisher dummy_diag_empty.status "Error", Warn, OK
  4. confirm by rqt_runtime_monitor
Screencast.from.2025.01.18.15.37.41.webm

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

Effects on launch file that run dummy_diag_publisher.
It looks like only in tier4_system_launch. #9959

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:system System design and integration. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Jan 18, 2025
Copy link

github-actions bot commented Jan 18, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@TetsuKawa TetsuKawa added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test run:clang-tidy-pr-review labels Jan 18, 2025
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.43%. Comparing base (ae436b3) to head (8581431).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
...y_diag_publisher/src/dummy_diag_publisher_core.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9958      +/-   ##
==========================================
- Coverage   29.47%   29.43%   -0.05%     
==========================================
  Files        1424     1427       +3     
  Lines      107880   107954      +74     
  Branches    42827    42839      +12     
==========================================
- Hits        31801    31772      -29     
- Misses      73010    73118     +108     
+ Partials     3069     3064       -5     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 29.45% <ø> (-0.02%) ⬇️ Carriedforward from 80eb07c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TetsuKawa TetsuKawa force-pushed the fix/add-autowre-prefix-to-dummy-diag-publisher branch from 29a7f30 to 8581431 Compare January 20, 2025 05:45
@TetsuKawa TetsuKawa marked this pull request as ready for review January 20, 2025 05:47
@TetsuKawa TetsuKawa requested a review from ito-san as a code owner January 20, 2025 05:47
Copy link
Contributor

@sasakisasaki sasakisasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick Comment

Looks good.

Reason for Approval

The changed files looks contains all the necessary fixes and it is also tested by ros2 launch. Thus, this PR is merge-able 👍

Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TetsuKawa TetsuKawa merged commit b132a88 into autowarefoundation:main Jan 22, 2025
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:clang-tidy-pr-review tag:require-cuda-build-and-test type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants