Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamic_avoidance): ignore oncoming crossing object #4548

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Aug 7, 2023

Description

This PR fixes the following bug where the ego will turn right and there is an oncoming vehicle, resulting in the avoidance on the wrong side.
image

Tests performed

planning simulator

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 7, 2023
@takayuki5168 takayuki5168 force-pushed the feat/dynamic-avoidance-ignore-oncoming-crossing-object branch from 6b28291 to edb7ffc Compare August 7, 2023 18:26
Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (f211031) 14.80% compared to head (9a52a2d) 14.80%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4548      +/-   ##
==========================================
- Coverage   14.80%   14.80%   -0.01%     
==========================================
  Files        1527     1527              
  Lines      105594   105608      +14     
  Branches    32066    32080      +14     
==========================================
- Hits        15638    15637       -1     
- Misses      72884    72899      +15     
  Partials    17072    17072              
Flag Coverage Δ *Carryforward flag
differential 13.09% <0.00%> (?)
total 14.81% <ø> (+<0.01%) ⬆️ Carriedforward from f211031

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ule/dynamic_avoidance/dynamic_avoidance_module.hpp 0.00% <ø> (ø)
...nner/include/behavior_path_planner/utils/utils.hpp 45.45% <ø> (ø)
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 0.00% <0.00%> (ø)
...ner/src/scene_module/dynamic_avoidance/manager.cpp 0.00% <0.00%> (ø)
.../scene_module/goal_planner/goal_planner_module.cpp 6.03% <0.00%> (ø)
...cene_module/start_planner/start_planner_module.cpp 4.09% <0.00%> (ø)
...ner/src/utils/goal_planner/geometric_pull_over.cpp 20.83% <0.00%> (ø)
...h_planner/src/utils/goal_planner/goal_searcher.cpp 2.05% <0.00%> (ø)
...planner/src/utils/goal_planner/shift_pull_over.cpp 3.60% <0.00%> (ø)
...ner/src/utils/start_planner/geometric_pull_out.cpp 9.67% <0.00%> (ø)
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 marked this pull request as ready for review August 8, 2023 01:49
@takayuki5168 takayuki5168 merged commit cdabb78 into autowarefoundation:main Aug 8, 2023
@takayuki5168 takayuki5168 deleted the feat/dynamic-avoidance-ignore-oncoming-crossing-object branch August 8, 2023 01:50
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Aug 9, 2023
…ndation#4548)

* feat(dynamic_avoidance): ignore oncoming crossing object

Signed-off-by: Takayuki Murooka <[email protected]>

* remove debug print

Signed-off-by: Takayuki Murooka <[email protected]>

* update config

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
…ndation#4548)

* feat(dynamic_avoidance): ignore oncoming crossing object

Signed-off-by: Takayuki Murooka <[email protected]>

* remove debug print

Signed-off-by: Takayuki Murooka <[email protected]>

* update config

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Nov 26, 2023
…ndation#4548)

* feat(dynamic_avoidance): ignore oncoming crossing object

Signed-off-by: Takayuki Murooka <[email protected]>

* remove debug print

Signed-off-by: Takayuki Murooka <[email protected]>

* update config

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Dec 25, 2023
…ndation#4548)

* feat(dynamic_avoidance): ignore oncoming crossing object

Signed-off-by: Takayuki Murooka <[email protected]>

* remove debug print

Signed-off-by: Takayuki Murooka <[email protected]>

* update config

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants