-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dynamic_avoidance): ignore oncoming crossing object #4548
Merged
takayuki5168
merged 3 commits into
autowarefoundation:main
from
tier4:feat/dynamic-avoidance-ignore-oncoming-crossing-object
Aug 8, 2023
Merged
feat(dynamic_avoidance): ignore oncoming crossing object #4548
takayuki5168
merged 3 commits into
autowarefoundation:main
from
tier4:feat/dynamic-avoidance-ignore-oncoming-crossing-object
Aug 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
6b28291
to
edb7ffc
Compare
Signed-off-by: Takayuki Murooka <[email protected]>
Merged
4 tasks
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4548 +/- ##
==========================================
- Coverage 14.80% 14.80% -0.01%
==========================================
Files 1527 1527
Lines 105594 105608 +14
Branches 32066 32080 +14
==========================================
- Hits 15638 15637 -1
- Misses 72884 72899 +15
Partials 17072 17072
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
kosuke55
approved these changes
Aug 8, 2023
takayuki5168
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 9, 2023
…ndation#4548) * feat(dynamic_avoidance): ignore oncoming crossing object Signed-off-by: Takayuki Murooka <[email protected]> * remove debug print Signed-off-by: Takayuki Murooka <[email protected]> * update config Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
LeoDriveProject
pushed a commit
to leo-drive/autoware.universe.golf
that referenced
this pull request
Aug 16, 2023
…ndation#4548) * feat(dynamic_avoidance): ignore oncoming crossing object Signed-off-by: Takayuki Murooka <[email protected]> * remove debug print Signed-off-by: Takayuki Murooka <[email protected]> * update config Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
takayuki5168
added a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 26, 2023
…ndation#4548) * feat(dynamic_avoidance): ignore oncoming crossing object Signed-off-by: Takayuki Murooka <[email protected]> * remove debug print Signed-off-by: Takayuki Murooka <[email protected]> * update config Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
takayuki5168
added a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 25, 2023
…ndation#4548) * feat(dynamic_avoidance): ignore oncoming crossing object Signed-off-by: Takayuki Murooka <[email protected]> * remove debug print Signed-off-by: Takayuki Murooka <[email protected]> * update config Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the following bug where the ego will turn right and there is an oncoming vehicle, resulting in the avoidance on the wrong side.
![image](https://private-user-images.githubusercontent.com/20228327/258896940-e6f3390d-2b74-4956-b0ef-a639b458d446.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNDU1MjksIm5iZiI6MTczOTI0NTIyOSwicGF0aCI6Ii8yMDIyODMyNy8yNTg4OTY5NDAtZTZmMzM5MGQtMmI3NC00OTU2LWIwZWYtYTYzOWI0NThkNDQ2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDAzNDAyOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZhNGY1YTkzYjc3NGJiOTRmMzA5ZGJlOTIyZDI5ZGRkMTdhNGFkMGExYzc2NTZhODQwZjM2M2U4MmU2NTNjZGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.3Syxi4pACvNGC3fnRL5GO25ODEQtZFY83rNy2gh3bGY)
Tests performed
planning simulator
Effects on system behavior
Nothing
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.