-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: take dummy objects' height into calculation when locating their Z position #4195
Conversation
fix: consider dummy objects' height when locating its Z position
Thank you for your PR. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4195 +/- ##
==========================================
- Coverage 14.28% 14.26% -0.03%
==========================================
Files 1575 1580 +5
Lines 108541 108753 +212
Branches 31424 31420 -4
==========================================
+ Hits 15507 15509 +2
- Misses 76164 76377 +213
+ Partials 16870 16867 -3
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Tier4Guan Could you check to pass for CI? |
@yukkysaito Thanks for your review. I ran all CI again. |
Description
close #3111
fix: take dummy objects' height into calculation when locating their Z position
Related links
Tests performed
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.