Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: take dummy objects' height into calculation when locating their Z position #4195

Merged
merged 5 commits into from
Jul 12, 2023

Conversation

Tier4Guan
Copy link
Contributor

@Tier4Guan Tier4Guan commented Jul 7, 2023

Description

close #3111

fix: take dummy objects' height into calculation when locating their Z position

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Tier4Guan added 2 commits July 4, 2023 14:53
fix: consider dummy objects' height when locating its Z position
@Tier4Guan Tier4Guan requested a review from yukkysaito as a code owner July 7, 2023 03:05
@github-actions github-actions bot added the component:simulation Virtual environment setups and simulations. (auto-assigned) label Jul 7, 2023
@yukkysaito
Copy link
Contributor

Thank you for your PR.
I'll review later 👍

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (1419f32) 14.28% compared to head (f43ef1b) 14.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4195      +/-   ##
==========================================
- Coverage   14.28%   14.26%   -0.03%     
==========================================
  Files        1575     1580       +5     
  Lines      108541   108753     +212     
  Branches    31424    31420       -4     
==========================================
+ Hits        15507    15509       +2     
- Misses      76164    76377     +213     
+ Partials    16870    16867       -3     
Flag Coverage Δ *Carryforward flag
differential 4.21% <0.00%> (?)
total 14.26% <0.00%> (-0.03%) ⬇️ Carriedforward from 6b363dd

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ommon/perception_utils/src/traffic_light_utils.cpp 0.00% <0.00%> (ø)
...ation_map_loader/src/elevation_map_loader_node.cpp 0.00% <0.00%> (ø)
...d_map/pointcloud_based_occupancy_grid_map_node.cpp 0.00% <ø> (ø)
..._light_occlusion_predictor/occlusion_predictor.hpp 0.00% <0.00%> (ø)
.../traffic_light_occlusion_predictor/src/nodelet.cpp 0.00% <0.00%> (ø)
...ht_occlusion_predictor/src/occlusion_predictor.cpp 0.00% <0.00%> (ø)
...ehavior_path_planner/src/utils/avoidance/utils.cpp 5.79% <ø> (+0.03%) ⬆️
...rivable_area_expansion/drivable_area_expansion.cpp 52.50% <ø> (+0.64%) ⬆️
...er/src/utils/drivable_area_expansion/expansion.cpp 30.55% <ø> (+1.24%) ⬆️
...path_planner/test/test_drivable_area_expansion.cpp 34.00% <ø> (ø)
... and 1 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota satoshi-ota self-assigned this Jul 7, 2023
@satoshi-ota satoshi-ota self-requested a review July 7, 2023 09:16
@yukkysaito
Copy link
Contributor

LGTM
Before
image (5)

After
image

yukkysaito

This comment was marked as duplicate.

@yukkysaito yukkysaito self-requested a review July 9, 2023 07:31
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukkysaito
Copy link
Contributor

yukkysaito commented Jul 9, 2023

@Tier4Guan Could you check to pass for CI?

@satoshi-ota
Copy link
Contributor

@yukkysaito Thanks for your review. I ran all CI again.

@satoshi-ota satoshi-ota linked an issue Jul 10, 2023 that may be closed by this pull request
3 tasks
@satoshi-ota satoshi-ota merged commit 6bf539b into autowarefoundation:main Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:simulation Virtual environment setups and simulations. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dummy object is below the ground
3 participants