Skip to content

Commit

Permalink
fix: take dummy objects' height into calculation when locating their …
Browse files Browse the repository at this point in the history
…Z position (#4195)

* Update node.cpp

fix: consider dummy objects' height when locating its Z position

* style(pre-commit): autofix

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
  • Loading branch information
Tier4Guan and pre-commit-ci[bot] authored Jul 12, 2023
1 parent 3b0ef6a commit 6bf539b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions simulator/dummy_perception_publisher/src/node.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ void DummyPerceptionPublisherNode::objectCallback(
ros_map2base_link = tf_buffer_.lookupTransform(
"map", "base_link", rclcpp::Time(0), rclcpp::Duration::from_seconds(0.5));
object.initial_state.pose_covariance.pose.position.z =
ros_map2base_link.transform.translation.z;
ros_map2base_link.transform.translation.z + 0.5 * object.shape.dimensions.z;
} catch (tf2::TransformException & ex) {
RCLCPP_WARN_SKIPFIRST_THROTTLE(get_logger(), *get_clock(), 5000, "%s", ex.what());
return;
Expand Down Expand Up @@ -406,7 +406,7 @@ void DummyPerceptionPublisherNode::objectCallback(
ros_map2base_link = tf_buffer_.lookupTransform(
"map", "base_link", rclcpp::Time(0), rclcpp::Duration::from_seconds(0.5));
objects_.at(i).initial_state.pose_covariance.pose.position.z =
ros_map2base_link.transform.translation.z;
ros_map2base_link.transform.translation.z + 0.5 * objects_.at(i).shape.dimensions.z;
} catch (tf2::TransformException & ex) {
RCLCPP_WARN_SKIPFIRST_THROTTLE(get_logger(), *get_clock(), 5000, "%s", ex.what());
return;
Expand Down

0 comments on commit 6bf539b

Please sign in to comment.