Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge develop into feature/number-field #528

Conversation

georgehristov
Copy link
Collaborator

update the feature/number-field branch

DarkSide666 and others added 30 commits December 11, 2019 00:20
* fix one test

* Setting current dependencies

* use custom exec button on edit action

* Update Model.php

* remove class, use seed

Co-authored-by: Imants Horsts <[email protected]>
* use the object default add field property

* no need for double brackets.

* force tests

Co-authored-by: Romans Malinovskis <[email protected]>
Co-authored-by: Imants Horsts <[email protected]>
* more tests

* Apply fixes from StyleCI
* better implementation for addFields() and test cases

* Apply fixes from StyleCI

* use shorthand method

* simplify code

* implement `exprNow()` method. Rely on dsql PR.

* Apply fixes from StyleCI

* pass

* add docs

Co-authored-by: Romans Malinovskis <[email protected]>
* Fix/ Small Action related fix

- Set Edit action exec button labe lto 'Save' by default
 - Set Edit action exec button colot to blue by default
- Set default description for Add action in model
- Add method to retreive model from Action

* Apply fixes from StyleCI

* fix comment

Co-authored-by: Imants Horsts <[email protected]>
* Accept any DateTimeInterface impl. for datetime

* Fix DateTime::getTimezone method name

* Fix setTimezone for any instance of DateTimeInterface
…rmalization/cloning issue (atk4#504)

* Fix datetime normalization cloning

* Add microseconds persistence support for datetime/time types

Co-authored-by: Imants Horsts <[email protected]>
* Implement `getTitles()` method

* Apply fixes from StyleCI
* Hook args must be an array

* Fix hook onHook() usage
# Conflicts:
#	composer.json
#	src/Field.php
#	src/Model.php
#	src/Persistence/SQL.php
#	src/Reference/HasOne.php
# Conflicts:
#	src/Field/Callback.php
#	src/Reference/HasOne_SQL.php
@DarkSide666 DarkSide666 requested a review from romaninsh March 24, 2020 19:10
@georgehristov georgehristov force-pushed the feature/number-field-merge-develop branch from 306bf88 to b362404 Compare March 25, 2020 13:17
@romaninsh
Copy link
Member

@georgehristov - is this up-to-date? it shows awfully lot of changes..

@romaninsh
Copy link
Member

@georgehristov AHHHHH... ok got it :D

@romaninsh romaninsh merged commit 48aa012 into atk4:feature/number-field Mar 28, 2020
@georgehristov georgehristov deleted the feature/number-field-merge-develop branch March 30, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants