-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: merge develop into feature/number-field #528
Merged
romaninsh
merged 36 commits into
atk4:feature/number-field
from
georgehristov:feature/number-field-merge-develop
Mar 28, 2020
Merged
chore: merge develop into feature/number-field #528
romaninsh
merged 36 commits into
atk4:feature/number-field
from
georgehristov:feature/number-field-merge-develop
Mar 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix one test * Setting current dependencies * use custom exec button on edit action * Update Model.php * remove class, use seed Co-authored-by: Imants Horsts <[email protected]>
* use the object default add field property * no need for double brackets. * force tests Co-authored-by: Romans Malinovskis <[email protected]> Co-authored-by: Imants Horsts <[email protected]>
* more tests * Apply fixes from StyleCI
* better implementation for addFields() and test cases * Apply fixes from StyleCI * use shorthand method * simplify code * implement `exprNow()` method. Rely on dsql PR. * Apply fixes from StyleCI * pass * add docs Co-authored-by: Romans Malinovskis <[email protected]>
* Fix/ Small Action related fix - Set Edit action exec button labe lto 'Save' by default - Set Edit action exec button colot to blue by default - Set default description for Add action in model - Add method to retreive model from Action * Apply fixes from StyleCI * fix comment Co-authored-by: Imants Horsts <[email protected]>
* Accept any DateTimeInterface impl. for datetime * Fix DateTime::getTimezone method name * Fix setTimezone for any instance of DateTimeInterface
…rmalization/cloning issue (atk4#504) * Fix datetime normalization cloning * Add microseconds persistence support for datetime/time types Co-authored-by: Imants Horsts <[email protected]>
* Implement `getTitles()` method * Apply fixes from StyleCI
* Hook args must be an array * Fix hook onHook() usage
# Conflicts: # composer.json # src/Field.php # src/Model.php # src/Persistence/SQL.php # src/Reference/HasOne.php
# Conflicts: # src/Field/Callback.php # src/Reference/HasOne_SQL.php
306bf88
to
b362404
Compare
…ehristov/data into feature/number-field-merge-develop
@georgehristov - is this up-to-date? it shows awfully lot of changes.. |
@georgehristov AHHHHH... ok got it :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update the feature/number-field branch