Callback fields should not be sortable #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #516 +/- ##
==========================================
Coverage 86.99% 87.00%
Complexity 1241 1241
==========================================
Files 28 28
Lines 2707 2708 +1
==========================================
+ Hits 2355 2356 +1
Misses 352 352 Continue to review full report at Codecov.
|
romaninsh
approved these changes
Feb 29, 2020
romaninsh
added a commit
that referenced
this pull request
Mar 28, 2020
* badge * Feature/set custom edit exec button (#490) * fix one test * Setting current dependencies * use custom exec button on edit action * Update Model.php * remove class, use seed Co-authored-by: Imants Horsts <[email protected]> * model default add field property (#454) * use the object default add field property * no need for double brackets. * force tests Co-authored-by: Romans Malinovskis <[email protected]> Co-authored-by: Imants Horsts <[email protected]> * Fix empty array condition (#498) * more tests * Apply fixes from StyleCI * better implementation for addFields() and test cases (#499) * better implementation for addFields() and test cases * Apply fixes from StyleCI * use shorthand method * simplify code * implement `exprNow()` method. Rely on dsql PR. * Apply fixes from StyleCI * pass * add docs Co-authored-by: Romans Malinovskis <[email protected]> * Fix/ Small Action related fix (#502) * Fix/ Small Action related fix - Set Edit action exec button labe lto 'Save' by default - Set Edit action exec button colot to blue by default - Set default description for Add action in model - Add method to retreive model from Action * Apply fixes from StyleCI * fix comment Co-authored-by: Imants Horsts <[email protected]> * update multiple delete example (#503) * now supports multiple filter options in getFields() * Apply fixes from StyleCI * Accept any DateTimeInterface impl. for datetime (#505) * Accept any DateTimeInterface impl. for datetime * Fix DateTime::getTimezone method name * Fix setTimezone for any instance of DateTimeInterface * Add microseconds persistence support for datetime/time types + fix normalization/cloning issue (#504) * Fix datetime normalization cloning * Add microseconds persistence support for datetime/time types Co-authored-by: Imants Horsts <[email protected]> * include comment about hooks and example how to execute them (#510) * update composer * Update release-drafter.yml * Update bundler.yml * Fix hasOne relation seed processing. It should replace not merge. (#512) * New method $model->getTitles() (#513) * Implement `getTitles()` method * Apply fixes from StyleCI * Update unit-tests.yml * migration to migrator * rename addHook to onHook (#514) * fix #944 (#516) * allow dots in table names, fix #515, fix #517 * Apply fixes from StyleCI * Do not fail-fast PHP test matrix (#522) * Simplify code (#519) * Update release-drafter.yml * Update release-drafter.yml * Fix hook trait usage (#525) * Hook args must be an array * Fix hook onHook() usage * Apply fixes from StyleCI * initialization of fields and handling of expressions * Apply fixes from StyleCI * introduce hasPersistence and retrieval of setting * Apply fixes from StyleCI Co-authored-by: Imants Horsts <[email protected]> Co-authored-by: Mimo <[email protected]> Co-authored-by: Romans Malinovskis <[email protected]> Co-authored-by: Alain Belair <[email protected]> Co-authored-by: DarkSide <[email protected]> Co-authored-by: Michael Voříšek <[email protected]>
DarkSide666
added a commit
that referenced
this pull request
Apr 8, 2020
* wip * wip * fixes * Feature/test1 (#483) * fixes * testtisg * wip * test * backmerge master * normalize everything * added locale test (#485) * added locale test * Apply fixes from StyleCI * wip * wip * Apply fixes from StyleCI * Update CHANGELOG.md * Implement #386 (#477) * Implement #386 * Apply fixes from StyleCI * Update Field.php * Update Model.php * Update Helper.php * Apply fixes from StyleCI * move functionality to atk4/core * Apply fixes from StyleCI * fix traits * Apply fixes from StyleCI * fix typo * Feature/pgsql test (#486) * fix one test * Setting current dependencies * wip * wip * Add matrix testing (#492) * Test using matrix * wip * wip * wip * clean up bundler * clean up bundler (#493) * wip * Fix/delete callback (#488) * fix one test * Setting current dependencies * fix/delete callback * Update composer.json * Fix/persistence sql condition (#487) * fix one test * Setting current dependencies * fix wrong assignment of value as condition * Update composer.json * Update SQL.php * Feature remove specified action (#489) * fix one test * Setting current dependencies * add method to remove specified action(s) from model * Update Model.php * spaces * Feature/add confirmation callback argument (#491) * fix one test * Setting current dependencies * pass the action object as argument to confirmation callback * badge * Feature/set custom edit exec button (#490) * fix one test * Setting current dependencies * use custom exec button on edit action * Update Model.php * remove class, use seed Co-authored-by: Imants Horsts <[email protected]> * model default add field property (#454) * use the object default add field property * no need for double brackets. * force tests Co-authored-by: Romans Malinovskis <[email protected]> Co-authored-by: Imants Horsts <[email protected]> * Fix empty array condition (#498) * more tests * Apply fixes from StyleCI * better implementation for addFields() and test cases (#499) * better implementation for addFields() and test cases * Apply fixes from StyleCI * use shorthand method * simplify code * implement `exprNow()` method. Rely on dsql PR. * Apply fixes from StyleCI * pass * add docs Co-authored-by: Romans Malinovskis <[email protected]> * Fix/ Small Action related fix (#502) * Fix/ Small Action related fix - Set Edit action exec button labe lto 'Save' by default - Set Edit action exec button colot to blue by default - Set default description for Add action in model - Add method to retreive model from Action * Apply fixes from StyleCI * fix comment Co-authored-by: Imants Horsts <[email protected]> * update multiple delete example (#503) * now supports multiple filter options in getFields() * Apply fixes from StyleCI * Accept any DateTimeInterface impl. for datetime (#505) * Accept any DateTimeInterface impl. for datetime * Fix DateTime::getTimezone method name * Fix setTimezone for any instance of DateTimeInterface * Add microseconds persistence support for datetime/time types + fix normalization/cloning issue (#504) * Fix datetime normalization cloning * Add microseconds persistence support for datetime/time types Co-authored-by: Imants Horsts <[email protected]> * include comment about hooks and example how to execute them (#510) * update composer * Update release-drafter.yml * Update bundler.yml * Fix hasOne relation seed processing. It should replace not merge. (#512) * New method $model->getTitles() (#513) * Implement `getTitles()` method * Apply fixes from StyleCI * Update unit-tests.yml * migration to migrator * rename addHook to onHook (#514) * fix #944 (#516) * allow dots in table names, fix #515, fix #517 * Apply fixes from StyleCI * Do not fail-fast PHP test matrix (#522) * Simplify code (#519) * Update release-drafter.yml * Update release-drafter.yml * Fix hook trait usage (#525) * Hook args must be an array * Fix hook onHook() usage * Implement addWith() (#527) * Implement addWith() * Apply fixes from StyleCI * implement `addWith` * add docs * add note * Update unit-tests.yml * Update unit-tests.yml * Update unit-tests.yml * Update unit-tests.yml * Update unit-tests.yml * Update unit-tests.yml * Update unit-tests.yml * Update unit-tests.yml * Update unit-tests.yml * Update unit-tests.yml * Update unit-tests.yml * Action should also support `fields===true` value (#531) * Fix LIKE conditions for Array and SQL persistences (#532) * Fix LIKE conditions - fix fix (#535) * fix #533 (#537) * Fix value trim (#538) * introduce sql null condition test (#540) * introduce test on condition with null value * include mesage in SQL exception details * Fix typo * Convert scalar class names to ::class (#544) * Fix CS - do not import classes without namespace * Use null coalescing operator instead of isset (#545) * Use null coalescing operator instead of isset * Fix tests * Fix refactorability for "owner" (#543) * Fix refactorability for "owner" * Typehint for elements * Narrow phpdoc for SQL subtypes * Fix typos * Setting release dependencies Co-authored-by: Romans Malinovskis <[email protected]> Co-authored-by: Romans Malinovskis <[email protected]> Co-authored-by: Imants Horsts <[email protected]> Co-authored-by: Georgi Hristov <[email protected]> Co-authored-by: Mimo <[email protected]> Co-authored-by: Alain Belair <[email protected]> Co-authored-by: DarkSide <[email protected]> Co-authored-by: Michael Voříšek <[email protected]> Co-authored-by: GitHub Action <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relies on atk4/ui#972
Fix atk4/ui#944