Feature/set custom edit exec button

[georgehristov]

No description provided.

[DarkSide666]

I kind of understand what you wanted to implement with this, but please provide more info in PR description.
Also atk4/data should not depend on atk4/ui repo, so ... I don't think this is good idea to have.

[georgehristov]

In current develop version the add / edit modal button has the same label as the action so 'edit' action has label 'Edit'. I find this not so intuitive,
Introducing the 'execButton' option would allows devs to assign a custom button for the add/edit modal.
If data should not depend on ui then I will update so that only an array is passed and ui can then create the button from the array.

[DarkSide666]

I think that would be better, because really, data should not have ui dependency.
Maybe you can pass only array with caption there, and let ui decide which class to use by default?

I will add @romaninsh and @ibelar to help decide how to do this.

[PhilippGrashoff]

I also vote for the array seed, as that wouldnt instanciate the Button object right away but only when needed.

[georgehristov]

I was considering between a seed or only the button label and initially opted for the seed.
Now I believe it would be better if data passes the button label only.
Will update the branch.

[ibelar]

The actual implementation of UserAction executor allow for changing button label via the $action->caption and $action->description property .

For example, changing execBtn caption and description for add action would be:

$ac = $country->getAction('add');
$ac->caption = 'Click to Add '; // the execBtn label in UserAction executor, i.e. perform the action.
$ac->description = 'Add New';  // The btn label that trigger the action, i.e will show modal.

I think did should be ok for now. Perhaps later on we could implement a better way to support custom button in ActionExecutor\UserAction::class.

[romaninsh]

ok