Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept either singular or plural for CLI constraints #9196

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Accept either singular or plural for CLI constraints #9196

merged 1 commit into from
Nov 20, 2024

Conversation

charliermarsh
Copy link
Member

Summary

I find myself messing this up with --build-constraint vs. --build-constraints, and it turns out our own CLI isn't fully consistent here either.

@charliermarsh charliermarsh added the cli Related to the command line interface label Nov 18, 2024
@charliermarsh charliermarsh force-pushed the charlie/c branch 3 times, most recently from 44df63a to 24091dd Compare November 18, 2024 16:24
@charliermarsh charliermarsh requested a review from zanieb November 18, 2024 17:14
@charliermarsh
Copy link
Member Author

I'd be fine to make plural the default too (and singular an alias).

zanieb
zanieb approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm all for reducing rough edges in this way

@charliermarsh charliermarsh force-pushed the charlie/c branch 2 times, most recently from 6f8a835 to ea9a801 Compare November 20, 2024 15:08
@charliermarsh charliermarsh enabled auto-merge (squash) November 20, 2024 15:10
@charliermarsh charliermarsh merged commit 2ed180e into main Nov 20, 2024
64 checks passed
@charliermarsh charliermarsh deleted the charlie/c branch November 20, 2024 15:31
@BrewTestBot BrewTestBot mentioned this pull request Nov 20, 2024
Merged
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Nov 21, 2024
@tmeijn
build(deps): update astral-sh/uv to v0.5.4
e022e51 
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.5.3` -> `0.5.4` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>astral-sh/uv (astral-sh/uv)</summary>

### [`v0.5.4`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#054)

[Compare Source](astral-sh/uv@0.5.3...0.5.4)

##### Enhancements

-   Accept either singular or plural values for CLI requirements ([#&#8203;9196](astral-sh/uv#9196))
-   Add `--all-groups` to `uv sync`, `uv run`, `uv export`, and `uv tree` ([#&#8203;8892](astral-sh/uv#8892))
-   Add a progress bar to `uv tree --outdated` and `uv pip list --outdated` ([#&#8203;9284](astral-sh/uv#9284))
-   Add retries for Python downloads ([#&#8203;9274](astral-sh/uv#9274))
-   Use exponential backoff for publish retries ([#&#8203;9276](astral-sh/uv#9276))
-   Add manylinux target triples up to glibc 2.40 ([#&#8203;9234](astral-sh/uv#9234))

##### Performance

-   Parallelize network requests in `uv tree --outdated` ([#&#8203;9280](astral-sh/uv#9280))
-   Use `zlib-rs` on all platforms ([#&#8203;9264](astral-sh/uv#9264))

##### Bug fixes

-   Avoid validating extra and group sources in `build-system.requires` ([#&#8203;9273](astral-sh/uv#9273))
-   Catch retries with wrapped `reqwest` errors ([#&#8203;9253](astral-sh/uv#9253))
-   Sort hashes in `uv export` output ([#&#8203;9237](astral-sh/uv#9237))
-   Strip `--index` and `--default-index` from command header ([#&#8203;9288](astral-sh/uv#9288))

##### Documentation

-   Add breadcrumbs to the documentation ([#&#8203;9242](astral-sh/uv#9242))
-   Add minimum version to PyTorch guide ([#&#8203;9247](astral-sh/uv#9247))
-   Add support for anchor redirects with client-side js ([#&#8203;9212](astral-sh/uv#9212))
-   Improve content on project configuration ([#&#8203;9235](astral-sh/uv#9235))
-   Improve the project creation documentation ([#&#8203;9236](astral-sh/uv#9236))
-   Move the integration guides into the "Guides" section as a collapsed group ([#&#8203;9245](astral-sh/uv#9245))
-   Reorganize the project concept documentation ([#&#8203;9121](astral-sh/uv#9121))
-   Use the full screen height for the main content to stabilize the nav ([#&#8203;9153](astral-sh/uv#9153))

##### Error messages

-   Add dedicated warning for empty stdin ([#&#8203;9256](astral-sh/uv#9256))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
cli Related to the command line interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charliermarsh @zanieb