Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize the project concept documentation #9121

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Nov 14, 2024

  • Adds a collapsible section for the project concept
  • Splits the project concept document into several child documents.
  • Moves the workspace and dependencies documents to under the project section
  • Adds a mkdocs plugin for redirects, so links to the moved documents still work

I attempted to make the minimum required changes to the contents of the documents here. There is a lot of room for improvement on the content of each new child document. For review purposes, I want to do that work separately. I'd prefer if the review focused on this structure and idea rather than the content of the files.

I expect to do this to other documentation pages that would otherwise be very nested.

The project concept landing page and nav (collapsed by default) looks like this now:

Screenshot 2024-11-14 at 11 28 45 AM

@zanieb zanieb added the documentation Improvements or additions to documentation label Nov 14, 2024
@zanieb zanieb force-pushed the zb/docs-collapsible-project branch 5 times, most recently from e89217d to 134e999 Compare November 14, 2024 17:28
@zanieb zanieb marked this pull request as ready for review November 14, 2024 17:30
@AlexWaygood AlexWaygood self-requested a review November 14, 2024 19:18
mkdocs.template.yml Outdated Show resolved Hide resolved
@dhruvmanila
Copy link
Member

dhruvmanila commented Nov 15, 2024

I think splitting larger pages into does make sense. We should enable navigation.path (navigation path breadcrumbs) so that it's easy to understand where the user is currently at. It might be problematic because of the "Introduction" page that exists currently but that can possibly be solved.

I'm still a big fan of having a third dimension to navigation aka tabs where the top level sections go but that's an unrelated discussion.

@dhruvmanila
Copy link
Member

dhruvmanila commented Nov 15, 2024

One thing I noticed is that the footer seems to be a bit annoying when clicking on the "Projects" section because it occupies the entire screen width. I don't know if it's possible but limiting that only to the content region (and not the navigation and table of content) would be a good UX improvement IMO.

@zanieb zanieb force-pushed the zb/docs-collapsible-project branch from 134e999 to 3aa96a5 Compare November 15, 2024 15:47
@zanieb
Copy link
Member Author

zanieb commented Nov 15, 2024

I'm still a big fan of having a third dimension to navigation aka tabs where the top level sections go but that's an unrelated discussion.

Agree, it just makes it a lot harder to incrementally add more sections because it's a weird experience to switch to tabs without creating and populating a lot of child pages.

One thing I noticed is that the footer seems to be a bit annoying when clicking on the "Projects" section because it occupies the entire screen width. I don't know if it's possible but limiting that only to the content region (and not the navigation and table of content) would be a good UX improvement IMO.

I feel the same. In my larger reorg, I actually implemented this in an attempt to show more of the nav

Screenshot 2024-11-15 at 9 48 19 AM

However, this requires JS to dynamically move the element by editing the DOM (you can't style it up into the content).

I think we either need to fork our own theme and change it there, or... idk.

Edit: I had another idea that should solve this in the meantime — #9153

@zanieb
Copy link
Member Author

zanieb commented Nov 15, 2024

We should enable navigation.path (navigation path breadcrumbs) so that it's easy to understand where the user is currently at. It might be problematic because of the "Introduction" page that exists currently but that can possibly be solved.

This seems to have no effect locally for me, which is surprising. I agree it'd be nice to have — I think I tried turning it on previously but was annoyed by the "Introduction" page as you mentioned.

Base automatically changed from zb/docs-collapsible to main November 15, 2024 23:00
@zanieb zanieb force-pushed the zb/docs-collapsible-project branch 2 times, most recently from fd5f4f3 to c5ae128 Compare November 15, 2024 23:11
@dhruvmanila
Copy link
Member

This seems to have no effect locally for me, which is surprising.

Oh interesting. The following diff seems to be showing the breadcrumbs for me locally:

diff --git a/mkdocs.template.yml b/mkdocs.template.yml
index b68729f48..d8c88a525 100644
--- a/mkdocs.template.yml
+++ b/mkdocs.template.yml
@@ -4,7 +4,7 @@ theme:
   logo: assets/logo-letter.svg
   favicon: assets/favicon.ico
   features:
-    - navigation.collapsible
+    - navigation.path
     - navigation.instant
     - navigation.instant.prefetch
     - navigation.instant.progress

But, it does include the "Introduction":
Screenshot 2024-11-18 at 11 00 26 AM

In my larger reorg, I actually implemented this in an attempt to show more of the nav

This looks good. Is this a mockup or is the "reorg" a code change? I'm curious to look at the diff if it's available.

@zanieb zanieb force-pushed the zb/docs-collapsible-project branch from c5ae128 to c4fadcc Compare November 19, 2024 19:40
@zanieb zanieb merged commit ca9aaf1 into main Nov 19, 2024
64 checks passed
@zanieb zanieb deleted the zb/docs-collapsible-project branch November 19, 2024 19:52
zanieb added a commit that referenced this pull request Nov 19, 2024
…9153)

On large screens, we require scrolling below the fold for the next page
/ prev page navigation footer. This dramatically improves visibility of
the left nav when looking at small pages like section overviews.
Critically, this stops the height of the navigation from jumping around
depending on the page you're on. On small screens, the positioning is
unchanged since the nav is in a hamburger menu and it'd be annoying to
scroll.

Eventually, we could move the next / prev nav out of the footer and into
the content, e.g., as in
#9121 (comment).

These images don't quite do the change in experience justice. It's the
consistency when changing pages that feels the most different.

Before

<img width="1484" alt="Screenshot 2024-11-15 at 10 16 30 AM"
src="https://github.com/user-attachments/assets/e0729691-31ea-46cc-9679-636fb144eab7">

After

<img width="1474" alt="Screenshot 2024-11-15 at 10 15 26 AM"
src="https://github.com/user-attachments/assets/d01ae5cd-1347-45de-a294-fbd56b2d6fb5">
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Nov 21, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.5.3` -> `0.5.4` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>astral-sh/uv (astral-sh/uv)</summary>

### [`v0.5.4`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#054)

[Compare Source](astral-sh/uv@0.5.3...0.5.4)

##### Enhancements

-   Accept either singular or plural values for CLI requirements ([#&#8203;9196](astral-sh/uv#9196))
-   Add `--all-groups` to `uv sync`, `uv run`, `uv export`, and `uv tree` ([#&#8203;8892](astral-sh/uv#8892))
-   Add a progress bar to `uv tree --outdated` and `uv pip list --outdated` ([#&#8203;9284](astral-sh/uv#9284))
-   Add retries for Python downloads ([#&#8203;9274](astral-sh/uv#9274))
-   Use exponential backoff for publish retries ([#&#8203;9276](astral-sh/uv#9276))
-   Add manylinux target triples up to glibc 2.40 ([#&#8203;9234](astral-sh/uv#9234))

##### Performance

-   Parallelize network requests in `uv tree --outdated` ([#&#8203;9280](astral-sh/uv#9280))
-   Use `zlib-rs` on all platforms ([#&#8203;9264](astral-sh/uv#9264))

##### Bug fixes

-   Avoid validating extra and group sources in `build-system.requires` ([#&#8203;9273](astral-sh/uv#9273))
-   Catch retries with wrapped `reqwest` errors ([#&#8203;9253](astral-sh/uv#9253))
-   Sort hashes in `uv export` output ([#&#8203;9237](astral-sh/uv#9237))
-   Strip `--index` and `--default-index` from command header ([#&#8203;9288](astral-sh/uv#9288))

##### Documentation

-   Add breadcrumbs to the documentation ([#&#8203;9242](astral-sh/uv#9242))
-   Add minimum version to PyTorch guide ([#&#8203;9247](astral-sh/uv#9247))
-   Add support for anchor redirects with client-side js ([#&#8203;9212](astral-sh/uv#9212))
-   Improve content on project configuration ([#&#8203;9235](astral-sh/uv#9235))
-   Improve the project creation documentation ([#&#8203;9236](astral-sh/uv#9236))
-   Move the integration guides into the "Guides" section as a collapsed group ([#&#8203;9245](astral-sh/uv#9245))
-   Reorganize the project concept documentation ([#&#8203;9121](astral-sh/uv#9121))
-   Use the full screen height for the main content to stabilize the nav ([#&#8203;9153](astral-sh/uv#9153))

##### Error messages

-   Add dedicated warning for empty stdin ([#&#8203;9256](astral-sh/uv#9256))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants