-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize the project concept documentation #9121
Conversation
e89217d
to
134e999
Compare
I think splitting larger pages into does make sense. We should enable I'm still a big fan of having a third dimension to navigation aka tabs where the top level sections go but that's an unrelated discussion. |
One thing I noticed is that the footer seems to be a bit annoying when clicking on the "Projects" section because it occupies the entire screen width. I don't know if it's possible but limiting that only to the content region (and not the navigation and table of content) would be a good UX improvement IMO. |
134e999
to
3aa96a5
Compare
Agree, it just makes it a lot harder to incrementally add more sections because it's a weird experience to switch to tabs without creating and populating a lot of child pages.
I feel the same. In my larger reorg, I actually implemented this in an attempt to show more of the nav However, this requires JS to dynamically move the element by editing the DOM (you can't style it up into the content). I think we either need to fork our own theme and change it there, or... idk. Edit: I had another idea that should solve this in the meantime — #9153 |
This seems to have no effect locally for me, which is surprising. I agree it'd be nice to have — I think I tried turning it on previously but was annoyed by the "Introduction" page as you mentioned. |
fd5f4f3
to
c5ae128
Compare
c5ae128
to
c4fadcc
Compare
…9153) On large screens, we require scrolling below the fold for the next page / prev page navigation footer. This dramatically improves visibility of the left nav when looking at small pages like section overviews. Critically, this stops the height of the navigation from jumping around depending on the page you're on. On small screens, the positioning is unchanged since the nav is in a hamburger menu and it'd be annoying to scroll. Eventually, we could move the next / prev nav out of the footer and into the content, e.g., as in #9121 (comment). These images don't quite do the change in experience justice. It's the consistency when changing pages that feels the most different. Before <img width="1484" alt="Screenshot 2024-11-15 at 10 16 30 AM" src="https://github.com/user-attachments/assets/e0729691-31ea-46cc-9679-636fb144eab7"> After <img width="1474" alt="Screenshot 2024-11-15 at 10 15 26 AM" src="https://github.com/user-attachments/assets/d01ae5cd-1347-45de-a294-fbd56b2d6fb5">
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.5.3` -> `0.5.4` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.5.4`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#054) [Compare Source](astral-sh/uv@0.5.3...0.5.4) ##### Enhancements - Accept either singular or plural values for CLI requirements ([#​9196](astral-sh/uv#9196)) - Add `--all-groups` to `uv sync`, `uv run`, `uv export`, and `uv tree` ([#​8892](astral-sh/uv#8892)) - Add a progress bar to `uv tree --outdated` and `uv pip list --outdated` ([#​9284](astral-sh/uv#9284)) - Add retries for Python downloads ([#​9274](astral-sh/uv#9274)) - Use exponential backoff for publish retries ([#​9276](astral-sh/uv#9276)) - Add manylinux target triples up to glibc 2.40 ([#​9234](astral-sh/uv#9234)) ##### Performance - Parallelize network requests in `uv tree --outdated` ([#​9280](astral-sh/uv#9280)) - Use `zlib-rs` on all platforms ([#​9264](astral-sh/uv#9264)) ##### Bug fixes - Avoid validating extra and group sources in `build-system.requires` ([#​9273](astral-sh/uv#9273)) - Catch retries with wrapped `reqwest` errors ([#​9253](astral-sh/uv#9253)) - Sort hashes in `uv export` output ([#​9237](astral-sh/uv#9237)) - Strip `--index` and `--default-index` from command header ([#​9288](astral-sh/uv#9288)) ##### Documentation - Add breadcrumbs to the documentation ([#​9242](astral-sh/uv#9242)) - Add minimum version to PyTorch guide ([#​9247](astral-sh/uv#9247)) - Add support for anchor redirects with client-side js ([#​9212](astral-sh/uv#9212)) - Improve content on project configuration ([#​9235](astral-sh/uv#9235)) - Improve the project creation documentation ([#​9236](astral-sh/uv#9236)) - Move the integration guides into the "Guides" section as a collapsed group ([#​9245](astral-sh/uv#9245)) - Reorganize the project concept documentation ([#​9121](astral-sh/uv#9121)) - Use the full screen height for the main content to stabilize the nav ([#​9153](astral-sh/uv#9153)) ##### Error messages - Add dedicated warning for empty stdin ([#​9256](astral-sh/uv#9256)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
I attempted to make the minimum required changes to the contents of the documents here. There is a lot of room for improvement on the content of each new child document. For review purposes, I want to do that work separately. I'd prefer if the review focused on this structure and idea rather than the content of the files.
I expect to do this to other documentation pages that would otherwise be very nested.
The project concept landing page and nav (collapsed by default) looks like this now: