Use the full screen height for the main content to stabilize the nav #9153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @dhruvmanila |
zanieb
force-pushed
the
zb/docs-collapsible-project
branch
2 times, most recently
from
fd5f4f3 to
c5ae128
Compare
dhruvmanila
approved these changes
Nov 18, 2024
zanieb
force-pushed
the
zb/docs-nav-height
branch
from
b8336c9 to
0270a39
Compare
|
Ah sorry, rebased. |
zanieb
force-pushed
the
zb/docs-collapsible-project
branch
from
c5ae128 to
c4fadcc
Compare
zanieb
force-pushed
the
zb/docs-nav-height
branch
from
0270a39 to
332e985
Compare
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Nov 21, 2024
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.5.3` -> `0.5.4` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.5.4`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#054) [Compare Source](astral-sh/uv@0.5.3...0.5.4) ##### Enhancements - Accept either singular or plural values for CLI requirements ([#​9196](astral-sh/uv#9196)) - Add `--all-groups` to `uv sync`, `uv run`, `uv export`, and `uv tree` ([#​8892](astral-sh/uv#8892)) - Add a progress bar to `uv tree --outdated` and `uv pip list --outdated` ([#​9284](astral-sh/uv#9284)) - Add retries for Python downloads ([#​9274](astral-sh/uv#9274)) - Use exponential backoff for publish retries ([#​9276](astral-sh/uv#9276)) - Add manylinux target triples up to glibc 2.40 ([#​9234](astral-sh/uv#9234)) ##### Performance - Parallelize network requests in `uv tree --outdated` ([#​9280](astral-sh/uv#9280)) - Use `zlib-rs` on all platforms ([#​9264](astral-sh/uv#9264)) ##### Bug fixes - Avoid validating extra and group sources in `build-system.requires` ([#​9273](astral-sh/uv#9273)) - Catch retries with wrapped `reqwest` errors ([#​9253](astral-sh/uv#9253)) - Sort hashes in `uv export` output ([#​9237](astral-sh/uv#9237)) - Strip `--index` and `--default-index` from command header ([#​9288](astral-sh/uv#9288)) ##### Documentation - Add breadcrumbs to the documentation ([#​9242](astral-sh/uv#9242)) - Add minimum version to PyTorch guide ([#​9247](astral-sh/uv#9247)) - Add support for anchor redirects with client-side js ([#​9212](astral-sh/uv#9212)) - Improve content on project configuration ([#​9235](astral-sh/uv#9235)) - Improve the project creation documentation ([#​9236](astral-sh/uv#9236)) - Move the integration guides into the "Guides" section as a collapsed group ([#​9245](astral-sh/uv#9245)) - Reorganize the project concept documentation ([#​9121](astral-sh/uv#9121)) - Use the full screen height for the main content to stabilize the nav ([#​9153](astral-sh/uv#9153)) ##### Error messages - Add dedicated warning for empty stdin ([#​9256](astral-sh/uv#9256)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On large screens, we require scrolling below the fold for the next page / prev page navigation footer. This dramatically improves visibility of the left nav when looking at small pages like section overviews. Critically, this stops the height of the navigation from jumping around depending on the page you're on. On small screens, the positioning is unchanged since the nav is in a hamburger menu and it'd be annoying to scroll.
Eventually, we could move the next / prev nav out of the footer and into the content, e.g., as in #9121 (comment).
These images don't quite do the change in experience justice. It's the consistency when changing pages that feels the most different.
Before
After