Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to configure cards to enforce creation of unique tiles #4375

Closed
adamlodge opened this issue Dec 20, 2018 · 6 comments
Closed

Ability to configure cards to enforce creation of unique tiles #4375

adamlodge opened this issue Dec 20, 2018 · 6 comments
Assignees
@chiatt @adamlodge
Labels
Type: Bug Something isn't working Type: Enhancement

Comments

@adamlodge
Copy link
Collaborator

At present, it is possible on any card with cardinality of n to save tiles containing the same values over and over again. I would like to be able to configure a card in the card designer to define the set of nodes that must (in combination) be unique to save a tile to the database. This will impose a uniqueness integrity constraint that prevents entry of duplicate tiles.
@adamlodge adamlodge added sfport issue whose resolution may be supported by sfport project Type: Enhancement labels Dec 20, 2018
@adamlodge adamlodge mentioned this issue Jan 4, 2019
Closed
@adamlodge adamlodge mentioned this issue Jan 23, 2019
Closed
@chiatt chiatt removed the sfport issue whose resolution may be supported by sfport project label Mar 15, 2019
@chiatt chiatt self-assigned this Mar 15, 2019
chiatt added a commit that referenced this issue Mar 22, 2019
@chiatt
Add unique switches to ui re #4375
dbcefd1
chiatt added a commit that referenced this issue Mar 22, 2019
@chiatt
Add models to support unique constraints. re #4375
7f05eb7
@chiatt chiatt mentioned this issue Mar 22, 2019
Merged
chiatt added a commit that referenced this issue Mar 22, 2019
@chiatt
Updates UI to support unique constraints re #4375
98ee5db
chiatt added a commit that referenced this issue Mar 27, 2019
@chiatt
Adds backend constraint CRUD and serialization of constraints. re #4375
34df626
chiatt added a commit that referenced this issue Mar 27, 2019
@chiatt
Enforces unique constraint in the tile model re #4375
c1a96d6
chiatt added a commit that referenced this issue Mar 28, 2019
@chiatt
Adds unique to all instances flag. re #4375
059e727
chiatt added a commit that referenced this issue Mar 28, 2019
@chiatt
Fixes constraint reset. re #4375
f2c6592
chiatt added a commit that referenced this issue Mar 28, 2019
@chiatt
Addresses error in constraint migration, re #4375
8abcf12
chiatt added a commit that referenced this issue Mar 28, 2019
@chiatt
Imports card constraints when importing a graph, re #4375
a153f9b
@chiatt chiatt mentioned this issue Mar 28, 2019
Merged
chiatt added a commit that referenced this issue Mar 29, 2019
@chiatt
Fixes issues with constraint dirty state not updating properly. re #4375
340f277
@chiatt chiatt mentioned this issue Mar 29, 2019
Merged
@chiatt chiatt assigned adamlodge and unassigned chiatt Mar 29, 2019
@adamlodge
Copy link
Collaborator Author

meets reqt

chiatt added a commit that referenced this issue Apr 3, 2019
@chiatt
Prevents unique constraint validation from validating against the til…
39dbd83 
…e being saved #4375
@adamlodge
Copy link
Collaborator Author

I noticed a UI bug where this config apprears many times in the card design UI

Screen Shot 2019-04-03 at 11.45.25 AM.png

@adamlodge adamlodge reopened this Apr 3, 2019
@adamlodge adamlodge added the Type: Bug Something isn't working label Apr 3, 2019
@chiatt chiatt mentioned this issue Apr 3, 2019
Merged
chiatt added a commit that referenced this issue Apr 16, 2019
@chiatt
Prevents extra constraint records from getting saved to the database.…
bfc17c4 
… re #4375
@chiatt chiatt mentioned this issue Apr 16, 2019
Merged
@chiatt chiatt removed their assignment Apr 24, 2019
@chiatt
Copy link
Member

chiatt commented Apr 24, 2019

@adamlodge In the latest we shouldn't be creating these extra constraint records. However, once these extra constraint records are created they will need to be removed from the app using the django shell or the database.

@mradamcox mradamcox mentioned this issue May 15, 2019
Open
@adamlodge
Copy link
Collaborator Author

The unique constraint appears to work, but Arches is throwing the wrong error message when the constraint is violated.

Screen Shot 2019-12-23 at 1.08.13 PM.png

chiatt added a commit that referenced this issue Dec 24, 2019
@chiatt
Fixes issue with incorrect tile validation error messages. re #4375
538899d
@chiatt chiatt mentioned this issue Dec 24, 2019
Merged
@chiatt
Copy link
Member

chiatt commented Dec 24, 2019

@adamlodge Can you take another look at this? I fixed the issued and updated it on qa.archesproject.org

@adamlodge
Copy link
Collaborator Author

meets reqt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chiatt chiatt

@adamlodge adamlodge

Labels
Type: Bug Something isn't working Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chiatt @adamlodge