Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change "required" nodes to "not null" #4385

Closed
adamlodge opened this issue Jan 4, 2019 · 1 comment
Closed

change "required" nodes to "not null" #4385

adamlodge opened this issue Jan 4, 2019 · 1 comment

Comments

@adamlodge
Copy link
Collaborator

Documenting some thinking about the true meaning of ""Required" when configuring individual nodes in a card/resource model.

It seems to me that what we really mean is that if you are going to save a tile of data from the given card, then this particular node cannot be null. I would suggest we modify the verbiage to "not null" rather than "required".

Part of what I like about this is that it is consistent with typical RDBMS verbiage. You are essentially setting a not null constraint on that node in the resource model.

This change would go hand in hand with #4375

@chiatt
Copy link
Member

chiatt commented Mar 2, 2023

I like the idea of being consistent with RDBMS terms, but not null wouldn't be accurate because a geojson object with no features would still be 'required'. The same should be true for strings. You might store a string that has an object in the tile like so: {'en': ''}. It's technically not null, but you users should still be required to save a string value in order to save the card.

@chiatt chiatt closed this as completed Mar 2, 2023
@github-project-automation github-project-automation bot moved this to ✅ Done in pipeline Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants