Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issues with properly updating dirty state of node constraints #4726

Merged
merged 3 commits into from
Mar 29, 2019

Conversation

chiatt
Copy link
Member

@chiatt chiatt commented Mar 29, 2019

re #4375

constraint: koMapping.fromJS(constraint),
widgets: self.widgets()
});
constraintViewModel.constraint.nodes.subscribe(function(val){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'val' is defined but never used. (no-unused-vars)

});
constraintViewModel.constraint.nodes.subscribe(function(val){
self.toJSON();
}, self)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon. (semi)

@coveralls
Copy link

coveralls commented Mar 29, 2019

Coverage Status

Coverage decreased (-0.009%) to 42.95% when pulling 4e175fa on 4375_unique_tiles into ef9a0f2 on master.

@chiatt chiatt merged commit 76e563f into master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants