[event_v2] indexer logic update to handle migration #360

lightmark · 2024-05-01T06:19:46Z

PR description

In this PR we add event v2 migration indexing support.

PRs to handle:

[event v2] double emitting in account, coin, fungible asset and object and migrate move-examples aptos-core#10532
[event_v2] migrate the rest files in aptos-framework aptos-core#11688
[event_migration] migrate token v1 and other fixes of event v2 migration aptos-core#13147

Events to migrate

V1 + V2: means dedupe is required
only V1 or V2: means no dedupe is required due to no double emission.

Module	Event Name	Migration Note
account	KeyRotation	not indexed
aptos_account	DirectCoinTransferConfigUpdated	not indexed
coin	Deposit	only V1 or V2; not both
	Withdraw	only V1 or V2; not both
fungible_asset	Deposit	only V1 or V2; not both
	Withdraw	only V1 or V2; not both
	Frozen	only V1 or V2; not both
object	Transfer	V1 + V2
aptos_governance	CreateProposal	not indexed
	Vote	V1 + V2
	UpdateConfig	not indexed
block	NewBlock	not indexed
	UpdateEpochInterval	not indexed
multisig_account	-- all events --	not indexed
reconfiguration	NewEpoch	not indexed
stake	RegisterValidatorCandidate	not indexed
	SetOperator	not indexed
	AddStake	V1 + V2
	ReactivateStakeEvent	not indexed
	RotateConsensusKey	not indexed
	UpdateNetworkAndFullnodeAddresses	not indexed
	IncreaseLockup	not indexed
	JoinValidatorSet	not indexed
	DistributeRewards	V1 + V2
	UnlockStake	not indexed
	WithdrawStake	not indexed
	LeaveValidatorSet	not indexed
staking_contract	-- all events --	not indexed
vesting	-- all events --	not indexed
voting	-- all events --	not indexed
token	Mutation	V1 + V2
token_event_store	-- all events --	not indexed
token_transfers	-- all events --	not indexed

Notes

An example for event v2 migration.

whether a new field would be added can be seen here:
https://github.com/aptos-foundation/AIPs/blob/main/aips/aip-71.md
But the ground truth is in the code. Please verify.

lightmark · 2024-05-01T17:11:13Z

rust/processor/src/models/mod.rs

@@ -16,3 +18,8 @@ pub mod token_models;
 pub mod token_v2_models;
 pub mod transaction_metadata_model;
 pub mod user_transactions_models;
+


if v1 name is "XXXEvent" then v2 name is always "XXX" or "XXX<YYY..." and emitted just before v1 so if the preceding event exists and matches the name we will dedup/skip the current v1.

nit: can you add this as a comment in the code, and make a note that it's for events v2 migration?

CapCap · 2024-05-15T00:32:46Z

python/processors/nft_orderbooks/parsers/okx_parser.py

+            event.type_str != "0x3::token::DepositEvent"
+            and event.type_str != "0x3::token::Deposit"


since these are used in multiple places, would be good to make them a constant

This reverts commit 3551f40.

* [event_v2] an example code for event v2 migration * event v2 indexing. --------- Co-authored-by: Larry Liu <[email protected]>

Co-authored-by: Larry Liu <[email protected]>

lightmark force-pushed the lightmark/event_v2_migrate_example branch 4 times, most recently from b6fcdc7 to 107707c Compare May 1, 2024 17:07

lightmark requested review from larry-aptos, bowenyang007 and rtso May 1, 2024 17:07

lightmark commented May 1, 2024

View reviewed changes

lightmark force-pushed the lightmark/event_v2_migrate_example branch from 107707c to 5716a93 Compare May 1, 2024 17:17

larry-aptos force-pushed the lightmark/event_v2_migrate_example branch from 5716a93 to b42a35d Compare May 3, 2024 22:23

larry-aptos changed the title ~~[event_v2] an example code for event v2 migration~~ [event_v2] indexer logic update to handle migration May 6, 2024

[event_v2] an example code for event v2 migration

4d655b4

larry-aptos force-pushed the lightmark/event_v2_migrate_example branch from 0e42f40 to b5a0bb1 Compare May 15, 2024 00:01

larry-aptos added the build-rust label May 15, 2024

CapCap reviewed May 15, 2024

View reviewed changes

larry-aptos approved these changes May 15, 2024

View reviewed changes

event v2 indexing.

15a7fc9

larry-aptos force-pushed the lightmark/event_v2_migrate_example branch from 446be63 to 15a7fc9 Compare May 15, 2024 22:35

larry-aptos merged commit 3551f40 into main May 16, 2024
7 checks passed

larry-aptos deleted the lightmark/event_v2_migrate_example branch May 16, 2024 00:12

larry-aptos added a commit that referenced this pull request May 22, 2024

Revert "[event_v2] indexer logic update to handle migration (#360)"

fbe3068

This reverts commit 3551f40.

larry-aptos added a commit that referenced this pull request May 22, 2024

Revert "[event_v2] indexer logic update to handle migration (#360)"

8c41d26

This reverts commit 3551f40.

lightmark added a commit that referenced this pull request May 24, 2024

[event_v2] indexer logic update to handle migration (#360)

749e76b

* [event_v2] an example code for event v2 migration * event v2 indexing. --------- Co-authored-by: Larry Liu <[email protected]>

lightmark added a commit that referenced this pull request Jul 15, 2024

[event_v2] indexer logic update to handle migration (#360)

8f9cb42

* [event_v2] an example code for event v2 migration * event v2 indexing. --------- Co-authored-by: Larry Liu <[email protected]>

lightmark added a commit that referenced this pull request Oct 30, 2024

[event_v2] indexer logic update to handle migration (#360)

d6d2fba

* [event_v2] an example code for event v2 migration * event v2 indexing. --------- Co-authored-by: Larry Liu <[email protected]>

lightmark added a commit that referenced this pull request Nov 12, 2024

[event_v2] indexer logic update to handle migration (#360)

a59477d

* [event_v2] an example code for event v2 migration * event v2 indexing. --------- Co-authored-by: Larry Liu <[email protected]>

lightmark added a commit that referenced this pull request Nov 12, 2024

[event_v2] indexer logic update to handle migration (#360)

4af98d8

* [event_v2] an example code for event v2 migration * event v2 indexing. --------- Co-authored-by: Larry Liu <[email protected]>

lightmark added a commit that referenced this pull request Nov 13, 2024

[event_v2] indexer logic update to handle migration (#360)

9313b13

* [event_v2] an example code for event v2 migration * event v2 indexing. --------- Co-authored-by: Larry Liu <[email protected]>

lightmark added a commit that referenced this pull request Nov 21, 2024

[event_v2] indexer logic update to handle migration (#360)

bdb6f70

* [event_v2] an example code for event v2 migration * event v2 indexing. --------- Co-authored-by: Larry Liu <[email protected]>

lightmark added a commit that referenced this pull request Nov 27, 2024

[event_v2] indexer logic update to handle migration (#360)

d781c63

* [event_v2] an example code for event v2 migration * event v2 indexing. --------- Co-authored-by: Larry Liu <[email protected]>

lightmark added a commit that referenced this pull request Dec 5, 2024

[event_v2] indexer logic update to handle migration (#360)

d24865f

* [event_v2] an example code for event v2 migration * event v2 indexing. --------- Co-authored-by: Larry Liu <[email protected]>

lightmark added a commit that referenced this pull request Dec 5, 2024

[event_v2] indexer logic update to handle migration (#360)

a57e9d3

* [event_v2] an example code for event v2 migration * event v2 indexing. --------- Co-authored-by: Larry Liu <[email protected]>

lightmark added a commit that referenced this pull request Dec 5, 2024

[event_v2] indexer logic update to handle migration (#360) (#388)

4d82aa9

Co-authored-by: Larry Liu <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[event_v2] indexer logic update to handle migration #360

[event_v2] indexer logic update to handle migration #360

lightmark commented May 1, 2024 •

edited by larry-aptos

Loading

lightmark May 1, 2024

rtso May 11, 2024

CapCap May 15, 2024

		event.type_str != "0x3::token::DepositEvent"
		and event.type_str != "0x3::token::Deposit"

[event_v2] indexer logic update to handle migration #360

[event_v2] indexer logic update to handle migration #360

Conversation

lightmark commented May 1, 2024 • edited by larry-aptos Loading

PR description

Events to migrate

Notes

lightmark May 1, 2024

Choose a reason for hiding this comment

rtso May 11, 2024

Choose a reason for hiding this comment

CapCap May 15, 2024

Choose a reason for hiding this comment

lightmark commented May 1, 2024 •

edited by larry-aptos

Loading