New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[event_v2] indexer logic update to handle migration (#360) #388

Merged

lightmark merged 1 commit into main from lightmark/event_v2_migrate_example

Dec 5, 2024

Contributor

lightmark commented May 23, 2024

revert 8c41d26
with a fix

lightmark force-pushed the lightmark/event_v2_migrate_example branch 3 times, most recently from 1303843 to 749e76b Compare

May 24, 2024 14:13

lightmark requested review from rtso, bowenyang007 and larry-aptos

May 24, 2024 14:13

rtso reviewed

View reviewed changes

rust/processor/src/models/coin_models/coin_utils.rs Outdated Show resolved Hide resolved

rtso reviewed

View reviewed changes

rust/processor/src/models/mod.rs Outdated Show resolved Hide resolved

rtso reviewed

View reviewed changes

rust/processor/src/models/mod.rs Outdated Show resolved Hide resolved

rtso reviewed

View reviewed changes

rust/processor/src/processors/fungible_asset_processor.rs Outdated Show resolved Hide resolved

rtso reviewed

View reviewed changes

rust/processor/src/models/mod.rs Outdated Show resolved Hide resolved

bowenyang007 previously requested changes

View reviewed changes

Collaborator

bowenyang007 left a comment

pushing back to your queue. Is it still relevant? If so let's address the comments.

lightmark force-pushed the lightmark/event_v2_migrate_example branch 2 times, most recently from 3d03609 to a2f6c9b Compare

June 17, 2024 17:15

lightmark force-pushed the lightmark/event_v2_migrate_example branch from a2f6c9b to 4e61692 Compare

June 27, 2024 16:24

bowenyang007 dismissed their stale review

June 27, 2024 22:56

Unblocking

rtso requested changes

View reviewed changes

python/processors/nft_orderbooks/parsers/okx_parser.py Outdated Show resolved Hide resolved

python/processors/nft_orderbooks/parsers/okx_parser.py Outdated Show resolved Hide resolved

rust/processor/src/db/common/models/mod.rs Outdated Show resolved Hide resolved

rust/processor/src/processors/fungible_asset_processor.rs Outdated Show resolved Hide resolved

rust/processor/src/processors/token_v2_processor.rs Outdated Show resolved Hide resolved

lightmark force-pushed the lightmark/event_v2_migrate_example branch from 4e61692 to 8f9cb42 Compare

July 15, 2024 20:15

bowenyang007 reviewed

View reviewed changes

python/processors/nft_orderbooks/parsers/okx_parser.py

Collaborator

bowenyang007 Jul 22, 2024

can we remove these? we're no longer maintaining the python stuff anyway so it's not needed and we don't want to test it anyway.

Contributor Author

lightmark Jul 22, 2024

larry added these.
what to do with this file?

Collaborator

bowenyang007 Jul 23, 2024

uh just revert to how it was.

Collaborator

bowenyang007 commented Jul 23, 2024

Need a better summary and test plan. The summary cannot be "revert of a revert".

bowenyang007 reviewed

View reviewed changes

rust/processor/src/db/common/models/coin_models/coin_activities.rs Outdated Show resolved Hide resolved

bowenyang007 reviewed

View reviewed changes

rust/processor/src/db/common/models/coin_models/coin_activities.rs Outdated Show resolved Hide resolved

lightmark force-pushed the lightmark/event_v2_migrate_example branch from 8f9cb42 to d6d2fba Compare

October 30, 2024 06:36

lightmark force-pushed the lightmark/event_v2_migrate_example branch from d6d2fba to a59477d Compare

November 12, 2024 23:17

Contributor Author

lightmark commented Nov 12, 2024

we will not do double emission.
refactored.

lightmark force-pushed the lightmark/event_v2_migrate_example branch 2 times, most recently from 4af98d8 to 9313b13 Compare

November 13, 2024 08:36

lightmark force-pushed the lightmark/event_v2_migrate_example branch from 9313b13 to bdb6f70 Compare

November 21, 2024 17:58

codecov bot commented Nov 21, 2024 •

edited

Loading

Codecov Report

Attention: Patch coverage is 42.31884% with 199 lines in your changes missing coverage. Please review.

Project coverage is 49.2%. Comparing base (fbe2cf7) to head (a57e9d3).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...b/postgres/models/token_models/token_activities.rs	0.0%	72 Missing ⚠️
...gres/models/token_v2_models/v2_token_activities.rs	32.8%	43 Missing ⚠️
.../db/postgres/models/coin_models/coin_activities.rs	0.0%	35 Missing ⚠️
...src/db/postgres/models/token_models/token_utils.rs	40.3%	34 Missing ⚠️
...set_models/parquet_v2_fungible_asset_activities.rs	0.0%	10 Missing ⚠️
...src/db/postgres/models/stake_models/stake_utils.rs	77.7%	2 Missing ⚠️
.../postgres/models/token_v2_models/v2_token_utils.rs	88.2%	2 Missing ⚠️
...s/parquet_processors/parquet_token_v2_processor.rs	0.0%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##            main    #388     +/-   ##
=======================================
+ Coverage   48.9%   49.2%   +0.3%     
=======================================
  Files        186     186             
  Lines      24900   25210    +310     
=======================================
+ Hits       12189   12422    +233     
- Misses     12711   12788     +77

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lightmark force-pushed the lightmark/event_v2_migrate_example branch from bdb6f70 to d781c63 Compare

November 27, 2024 00:58

lightmark force-pushed the lightmark/event_v2_migrate_example branch from d781c63 to d24865f Compare

December 5, 2024 03:34


          [event_v2] indexer logic update to handle migration (#360)

a57e9d3

* [event_v2] an example code for event v2 migration

* event v2 indexing.

---------

Co-authored-by: Larry Liu <[email protected]>

lightmark force-pushed the lightmark/event_v2_migrate_example branch from d24865f to a57e9d3 Compare

December 5, 2024 17:06

rtso approved these changes

View reviewed changes

lightmark merged commit 4d82aa9 into main

11 checks passed

lightmark deleted the lightmark/event_v2_migrate_example branch

December 5, 2024 20:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet