Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[event_migration] migrate token v1 and other fixes of event v2 migration #13147

Merged
merged 2 commits into from
May 16, 2024

Conversation

lightmark
Copy link
Contributor

Description

we may want to migrate this as well.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@lightmark lightmark requested a review from areshand as a code owner May 1, 2024 05:08
Copy link

trunk-io bot commented May 1, 2024

⏱️ 4h 25m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-targeted-unit-tests 1h 25m 🟥🟩🟩🟩
rust-move-unit-coverage 1h 15m 🟩🟩🟩🟩
rust-move-tests 42m 🟩🟩🟩🟩
rust-lints 22m 🟩🟩🟩🟩
run-tests-main-branch 18m 🟩🟩🟩🟩
general-lints 7m 🟩🟩🟩🟩
cli-e2e-tests / run-cli-tests 6m 🟩
check-dynamic-deps 5m 🟩🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩
file_change_determinator 46s 🟩🟩🟩🟩
file_change_determinator 31s 🟩🟩🟩
permission-check 12s 🟩🟩🟩
permission-check 9s 🟩🟩🟩
permission-check 7s 🟩🟩🟩
permission-check 7s 🟩🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@lightmark lightmark requested a review from bowenyang007 May 1, 2024 05:08
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.5%. Comparing base (8c6963d) to head (4e5faa8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13147   +/-   ##
=======================================
  Coverage    57.5%    57.5%           
=======================================
  Files         832      832           
  Lines      198522   198522           
=======================================
  Hits       114269   114269           
  Misses      84253    84253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lightmark lightmark force-pushed the lightmark/event_migration_fix_token branch 2 times, most recently from 709449b to 871e72d Compare May 1, 2024 18:26
@lightmark lightmark force-pushed the lightmark/event_migration_fix_token branch from 871e72d to 8562b7c Compare May 1, 2024 19:15
@lightmark lightmark changed the title [event_migration] migrate token v1 [event_migration] migrate token v1 and other fixes of event v2 migration May 1, 2024
Copy link
Contributor

@larry-aptos larry-aptos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for indexer side.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@lightmark lightmark force-pushed the lightmark/event_migration_fix_token branch from 8562b7c to 4e5faa8 Compare May 16, 2024 16:30

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 4e5faa81b2cf4efe79828a24c8ffeb92eb3a1148

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 4e5faa81b2cf4efe79828a24c8ffeb92eb3a1148 (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 5029.232554577915 txn/s, latency: 6011.536878554393 ms, (p50: 4900 ms, p90: 10800 ms, p99: 11500 ms), latency samples: 218040
2. Upgrading first Validator to new version: 4e5faa81b2cf4efe79828a24c8ffeb92eb3a1148
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1750.2288438046828 txn/s, latency: 16252.839876569944 ms, (p50: 18600 ms, p90: 22600 ms, p99: 22900 ms), latency samples: 92360
3. Upgrading rest of first batch to new version: 4e5faa81b2cf4efe79828a24c8ffeb92eb3a1148
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1642.8968303953495 txn/s, latency: 16784.772544283413 ms, (p50: 19200 ms, p90: 22100 ms, p99: 22700 ms), latency samples: 86940
4. upgrading second batch to new version: 4e5faa81b2cf4efe79828a24c8ffeb92eb3a1148
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2600.2302919301815 txn/s, latency: 12047.936300844205 ms, (p50: 9900 ms, p90: 17000 ms, p99: 18100 ms), latency samples: 104240
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 4e5faa81b2cf4efe79828a24c8ffeb92eb3a1148 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 4e5faa81b2cf4efe79828a24c8ffeb92eb3a1148

two traffics test: inner traffic : committed: 8326.210665714361 txn/s, latency: 4712.808884863259 ms, (p50: 4500 ms, p90: 5400 ms, p99: 10200 ms), latency samples: 3593640
two traffics test : committed: 99.97823552321789 txn/s, latency: 1827.1022727272727 ms, (p50: 1800 ms, p90: 2100 ms, p99: 2300 ms), latency samples: 1760
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.205, avg: 0.203", "QsPosToProposal: max: 0.242, avg: 0.212", "ConsensusProposalToOrdered: max: 0.404, avg: 0.393", "ConsensusOrderedToCommit: max: 0.376, avg: 0.363", "ConsensusProposalToCommit: max: 0.772, avg: 0.756"]
Max round gap was 1 [limit 4] at version 1723302. Max no progress secs was 4.861629 [limit 15] at version 1723302.
Test Ok

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite framework_upgrade success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 4e5faa81b2cf4efe79828a24c8ffeb92eb3a1148

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 4e5faa81b2cf4efe79828a24c8ffeb92eb3a1148 (PR)
Upgrade the nodes to version: 4e5faa81b2cf4efe79828a24c8ffeb92eb3a1148
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1225.443916146855 txn/s, submitted: 1227.1904957529791 txn/s, failed submission: 1.7465796061241476 txn/s, expired: 1.7465796061241476 txn/s, latency: 2403.2185195082843 ms, (p50: 2100 ms, p90: 3900 ms, p99: 5700 ms), latency samples: 112260
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1199.3568185546378 txn/s, submitted: 1201.343605112155 txn/s, failed submission: 1.9867865575173458 txn/s, expired: 1.9867865575173458 txn/s, latency: 2701.227912755384 ms, (p50: 2100 ms, p90: 4800 ms, p99: 7100 ms), latency samples: 108660
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 4e5faa81b2cf4efe79828a24c8ffeb92eb3a1148 passed
Upgrade the remaining nodes to version: 4e5faa81b2cf4efe79828a24c8ffeb92eb3a1148
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1109.254515052621 txn/s, submitted: 1111.315900688688 txn/s, failed submission: 2.0613856360672287 txn/s, expired: 2.0613856360672287 txn/s, latency: 2926.810251909973 ms, (p50: 2400 ms, p90: 4800 ms, p99: 6900 ms), latency samples: 96860
Test Ok

@lightmark lightmark merged commit 55a02a2 into main May 16, 2024
48 checks passed
@lightmark lightmark deleted the lightmark/event_migration_fix_token branch May 16, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants