Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 2.4.1-1 #1350

Closed
FeodorFitsner opened this issue Feb 26, 2017 · 5 comments
Closed

Ruby 2.4.1-1 #1350

FeodorFitsner opened this issue Feb 26, 2017 · 5 comments

Comments

@FeodorFitsner
Copy link
Member

FeodorFitsner commented Feb 26, 2017

Installer: https://github.com/larskanis/rubyinstaller2
Discussion: https://twitter.com/blowmage/status/835940096163471360
Silent installation instructions: https://github.com/larskanis/rubyinstaller2/wiki/FAQ

@FeodorFitsner FeodorFitsner added this to the 5-Mar-2017 milestone Feb 26, 2017
@FeodorFitsner FeodorFitsner modified the milestones: 5-Mar-2017, 19-Mar-2017 Mar 13, 2017
@FeodorFitsner
Copy link
Member Author

@larskanis
Copy link

While I really appreciate a pre-installed RubyInstaller-2.4 on appveyor, please note, that the rubyinstaller2 is still beta. I hope to have a release quality when ruby-2.4.1 comes out, but I wouldn't recommend to install it now. There are still some significant changes in the pipeline. Please wait for an official release.

@FeodorFitsner
Copy link
Member Author

That makes sense, thanks for commenting on that.

@larskanis
Copy link

@FeodorFitsner RubyInstaller-2.4.1 is finally released! It would be great, if it could be made available on Appveyor as a preinstalled program. Don't hesitate to contact me, if there are any issues with it.

@FeodorFitsner
Copy link
Member Author

Great news, thanks for the update! We'll try deploying it withing the nearest update (next week or so).

Iristyle added a commit to Iristyle/puppet that referenced this issue Jun 13, 2017
 - Now that RubyInstaller has produced an installer for Ruby 2.4.1 on
   Windows and AppVeyor has integrated it into their workflow per
   appveyor/ci#1350 we can move from 2.3 to
   2.4 given Puppet 5 will be shipping against 2.4
Iristyle added a commit to Iristyle/puppet that referenced this issue Jun 14, 2017
 - Now that RubyInstaller has produced an installer for Ruby 2.4.1 on
   Windows and AppVeyor has integrated it into their workflow per
   appveyor/ci#1350 we can move from 2.3 to
   2.4 given Puppet 5 will be shipping against 2.4

 - Update tests that behave differently under Ruby 2.4:

   * Ruby has changed how ~ resolves when no HOME, HOMEDRIVE or
     USERPROFILE has set. It no longer fails to resolve / causes an
     exception thanks to https://bugs.ruby-lang.org/issues/12695

     puppetlabs#5653 was the first pass
     in f4f5ccb but was incomplete.

   * Ruby has changed the implementation of sort_by! so that items
     already in order will not be returned in the same order. For
     instance, compare the behaviors between Ruby 2.3 and 2.4:

     [[1.0, 'a'], [1.0, 'b'], [1.0, 'c']].sort_by! { |i| i[0] }
       Ruby 2.3:
       [[1.0, "a"], [1.0, "b"], [1.0, "c"]]
       Ruby 2.4:
       [[1.0, "b"], [1.0, "c"], [1.0, "a"]]

     [[1.0, 'c'], [1.0, 'b'], [1.0, 'a']].sort_by! { |i| i[0] }
       Ruby 2.3:
       [[1.0, "c"], [1.0, "b"], [1.0, "a"]]
       Ruby 2.4:
       [[1.0, "b"], [1.0, "a"], [1.0, "c"]]
Iristyle added a commit to Iristyle/puppet that referenced this issue Jun 14, 2017
 - Now that RubyInstaller has produced an installer for Ruby 2.4.1 on
   Windows and AppVeyor has integrated it into their workflow per
   appveyor/ci#1350 we can move from 2.3 to
   2.4 given Puppet 5 will be shipping against 2.4

 - Update tests that behave differently under Ruby 2.4:

   * Ruby has changed how ~ resolves when no HOME, HOMEDRIVE or
     USERPROFILE has set. It no longer fails to resolve / causes an
     exception thanks to https://bugs.ruby-lang.org/issues/12695

     puppetlabs#5653 was the first pass
     in f4f5ccb but was incomplete.

   * Ruby has changed the implementation of sort_by! so that items
     already in order will not be returned in the same order. For
     instance, compare the behaviors between Ruby 2.3 and 2.4:

     [[1.0, 'a'], [1.0, 'b'], [1.0, 'c']].sort_by! { |i| i[0] }
       Ruby 2.3:
       [[1.0, "a"], [1.0, "b"], [1.0, "c"]]
       Ruby 2.4:
       [[1.0, "b"], [1.0, "c"], [1.0, "a"]]

     [[1.0, 'c'], [1.0, 'b'], [1.0, 'a']].sort_by! { |i| i[0] }
       Ruby 2.3:
       [[1.0, "c"], [1.0, "b"], [1.0, "a"]]
       Ruby 2.4:
       [[1.0, "b"], [1.0, "a"], [1.0, "c"]]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants