Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the ruby 2.4.1 release #5936

Merged
merged 2 commits into from
Mar 28, 2017
Merged

Use the ruby 2.4.1 release #5936

merged 2 commits into from
Mar 28, 2017

Conversation

thommay
Copy link
Contributor

@thommay thommay commented Mar 22, 2017

First, let's see if they've fixed rspec. Then we can bump omnibus-software and go from there

@lamont-granquist
Copy link
Contributor

looks like travis' rvm needs to get updated. you might be able to rvm get head && rvm install ruby-2.4.1 very early in the build, but that'll make it take a whole lot longer and kind of defeat the purpose...

@lamont-granquist lamont-granquist mentioned this pull request Mar 22, 2017
Closed
@mawatech
Copy link

The binary is available now:

https://s3.amazonaws.com/travis-rubies/binaries/ubuntu/12.04/x86_64/ruby-2.4.1.tar.bz2

Perhaps you can trigger a rebuild?

@thommay thommay force-pushed the tm/rubby_241 branch 3 times, most recently from 55982e5 to 249c5bd Compare March 23, 2017 15:35
@thommay thommay changed the title [WIP] Use the ruby 2.4.1 release Use the ruby 2.4.1 release Mar 23, 2017
@thommay
Copy link
Contributor Author

thommay commented Mar 23, 2017

@chef/maintainers assuming this goes green. Numbers look pretty tasty. I also think we should only test with 2.4.1 for 13; thoughts?

@lamont-granquist
Copy link
Contributor

yeah should bump up everything possible to 2.4.1 but should probably still test on both 2.3.3 and 2.4.1 for rake spec.

@lamont-granquist
bump ruby to 2.4.1
a3159a6 
Signed-off-by: Lamont Granquist <[email protected]>
@lamont-granquist
Copy link
Contributor

bumping the Gemfile.lock failed on chef-zero, need to investigate that in parallel.

bumping bundler to either 1.13.x or 1.14.x is also not working right now, and gets into fights with rake tasks, there's probably some additional uncrazysaucing that needs to happen.

smurawski
smurawski approved these changes Mar 28, 2017
View reviewed changes
Copy link
Contributor

@smurawski smurawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lamont-granquist
Copy link
Contributor

(appveyor is also still on ruby-2.3 because there's no ruby-2.4)

@smurawski
Copy link
Contributor

Re: appveyor and ruby 2.4 - appveyor/ci#1350

@lamont-granquist lamont-granquist merged commit 302f160 into master Mar 28, 2017
@lamont-granquist lamont-granquist deleted the tm/rubby_241 branch March 28, 2017 18:23
@tas50 tas50 added the Type: Enhancement Adds new functionality. label Apr 4, 2017
@chef chef locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@smurawski smurawski smurawski approved these changes

Assignees
No one assigned
Labels
Type: Enhancement Adds new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thommay @lamont-granquist @mawatech @smurawski @tas50