(maint) Switch AppVeyor to Ruby 2.4 from 2.3 #5975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These appveyor failures don't look like the ones we've been seeing against the other PRs. Are they legit failures? |
|
@MosesMendoza yeah I'm looking at them. |
Iristyle
force-pushed
the
maint/add-Ruby-241-AppVeyor
branch
from
5b42dbf to
32c21ff
Compare
|
Relates to some of the work done in #5653 Possible now thanks to appveyor/ci#1350 |
- Now that RubyInstaller has produced an installer for Ruby 2.4.1 on Windows and AppVeyor has integrated it into their workflow per appveyor/ci#1350 we can move from 2.3 to 2.4 given Puppet 5 will be shipping against 2.4 - Update tests that behave differently under Ruby 2.4: * Ruby has changed how ~ resolves when no HOME, HOMEDRIVE or USERPROFILE has set. It no longer fails to resolve / causes an exception thanks to https://bugs.ruby-lang.org/issues/12695 puppetlabs#5653 was the first pass in f4f5ccb but was incomplete. * Ruby has changed the implementation of sort_by! so that items already in order will not be returned in the same order. For instance, compare the behaviors between Ruby 2.3 and 2.4: [[1.0, 'a'], [1.0, 'b'], [1.0, 'c']].sort_by! { |i| i[0] } Ruby 2.3: [[1.0, "a"], [1.0, "b"], [1.0, "c"]] Ruby 2.4: [[1.0, "b"], [1.0, "c"], [1.0, "a"]] [[1.0, 'c'], [1.0, 'b'], [1.0, 'a']].sort_by! { |i| i[0] } Ruby 2.3: [[1.0, "c"], [1.0, "b"], [1.0, "a"]] Ruby 2.4: [[1.0, "b"], [1.0, "a"], [1.0, "c"]]
Iristyle
force-pushed
the
maint/add-Ruby-241-AppVeyor
branch
from
32c21ff to
b7311d9
Compare
|
CLA signed by all contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows and AppVeyor has integrated it into their workflow per
Ruby 2.4.1-1 appveyor/ci#1350 we can move from 2.3 to
2.4 given Puppet 5 will be shipping against 2.4