chore: Fixing the top padding for queries and JS empty state to match UI segment empty state #38365

ankitakinger · 2024-12-25T10:33:41Z

Description

Fixing the top padding for queries and JS empty state to match UI segment empty state

Automation

/ok-to-test tags="@tag.IDE"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12492225163
Commit: 7be7180
Cypress dashboard.
Tags: @tag.IDE
Spec:

Wed, 25 Dec 2024 11:07:53 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

New Features
- Introduced conditional rendering of the BlankState component to indicate when there are no items to display.
- Added a NoSearchResults component for clearer feedback when searches yield no results.
Bug Fixes
- Removed redundant rendering of the BlankState component to streamline the user interface.

…ment empty state

coderabbitai · 2024-12-25T10:33:48Z

Walkthrough

The pull request focuses on improving the empty state rendering in two components: ListJSObjects and ListQuery. The changes introduce conditional rendering of the BlankState component when no items are present, ensuring a consistent and informative user interface. By removing redundant BlankState implementations and adding specific rendering conditions, the code enhances the user experience when no items are available or search results are empty.

Changes

File	Change Summary
`app/client/src/pages/Editor/IDE/EditorPane/JS/List.tsx`	Conditional `BlankState` rendering when `itemGroups` is empty
`app/client/src/pages/Editor/IDE/EditorPane/Query/List.tsx`	Added conditional `BlankState` and `NoSearchResults` rendering

Assessment against linked issues

Objective	Addressed	Explanation
Fix top padding for Queries and JS empty state [#38364]	✅

Possibly related PRs

fix: Updating empty state message when searching items in queries segment #37636: Updates empty state message in ListQuery component
fix: remove gap between tabs and list #37242: Modifies List component rendering logic
chore: extract search and add to ads #38192: Introduces SearchAndAdd component replacement

Suggested labels

Bug, Production, IDE Product, Task, IDE Pod, ok-to-test

Suggested reviewers

hetunandu
albinAppsmith

Poem

🖥️ In the realm of empty states so bare,
Code whispers tales of UI with care
Blank spaces now speak with grace
No items? No problem! We'll embrace
A clean, informative interfacelair! 🧩

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

ankitakinger · 2024-12-25T10:34:07Z

/build-deploy-preview skip-tests=true

github-actions · 2024-12-25T10:34:28Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12492229274.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 38365.
recreate: .

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

app/client/src/pages/Editor/IDE/EditorPane/JS/List.tsx (1)

64-65: Retain clarity when checking for empty itemGroups.

Good call checking (!itemGroups || itemGroups.length === 0) before rendering BlankState. Consider making this expression more descriptive by extracting it into a helper variable, such as noJSObjects or isEmptyGroup, if you anticipate future reusability for clarity.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f078ec0 and 7be7180.

📒 Files selected for processing (2)

app/client/src/pages/Editor/IDE/EditorPane/JS/List.tsx (1 hunks)
app/client/src/pages/Editor/IDE/EditorPane/Query/List.tsx (1 hunks)

🔇 Additional comments (1)

app/client/src/pages/Editor/IDE/EditorPane/Query/List.tsx (1)

55-56: Ensure consistent styling of the BlankState across the app.

Presenting BlankState for an empty query list is a good user experience. However, confirm the padding, layout, and text remain consistent with the rest of the UI. Validate the design alignment with the blank states in other parts of the product (e.g., JS objects) to maintain a unified look.

github-actions · 2024-12-25T10:48:30Z

Deploy-Preview-URL: https://ce-38365.dp.appsmith.com

… UI segment empty state (#38365) ## Description Fixing the top padding for queries and JS empty state to match UI segment empty state Fixes [#38364](#38364) ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12492225163> > Commit: 7be7180 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12492225163&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` > Spec: > <hr>Wed, 25 Dec 2024 11:07:53 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **New Features** - Introduced conditional rendering of the `BlankState` component to indicate when there are no items to display. - Added a `NoSearchResults` component for clearer feedback when searches yield no results. - **Bug Fixes** - Removed redundant rendering of the `BlankState` component to streamline the user interface.

fixing the top padding for queries and JS empty state to match UI seg…

7be7180

…ment empty state

ankitakinger requested a review from hetunandu December 25, 2024 10:33

ankitakinger added the ok-to-test Required label for CI label Dec 25, 2024

github-actions bot added IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo labels Dec 25, 2024

github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Dec 25, 2024

coderabbitai bot reviewed Dec 25, 2024

View reviewed changes

hetunandu approved these changes Dec 25, 2024

View reviewed changes

ankitakinger merged commit 0605501 into release Dec 25, 2024
46 checks passed

ankitakinger deleted the fix/top-padding-ui-segment branch December 25, 2024 12:53

This was referenced Dec 26, 2024

feat: State Inspector #38368

Merged

fix: Minor changes in Datasource and API #38371

Merged

chore: debounce handle action updates #38349

Closed

This was referenced Dec 27, 2024

chore: Updating List item and List components in ADS to start using it in Entity explorer #38344

Merged

chore: CE code for datasource management #38394

Merged

chore: debounce handle action updates #38396

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Fixing the top padding for queries and JS empty state to match UI segment empty state #38365

chore: Fixing the top padding for queries and JS empty state to match UI segment empty state #38365

ankitakinger commented Dec 25, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented Dec 25, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

ankitakinger commented Dec 25, 2024

github-actions bot commented Dec 25, 2024

coderabbitai bot left a comment

github-actions bot commented Dec 25, 2024

chore: Fixing the top padding for queries and JS empty state to match UI segment empty state #38365

chore: Fixing the top padding for queries and JS empty state to match UI segment empty state #38365

Conversation

ankitakinger commented Dec 25, 2024 • edited by github-actions bot Loading

Description

Automation

🔍 Cypress test results

Communication

Summary by CodeRabbit

coderabbitai bot commented Dec 25, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

ankitakinger commented Dec 25, 2024

github-actions bot commented Dec 25, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 25, 2024

ankitakinger commented Dec 25, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented Dec 25, 2024 •

edited

Loading