Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Fix the top padding for Queries and JS empty state to match UI segment empty state #38364

Closed
ankitakinger opened this issue Dec 25, 2024 · 0 comments · Fixed by #38365
Assignees
Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo

Comments

@ankitakinger
Copy link
Contributor

ankitakinger commented Dec 25, 2024

Queries and JS empty state has a different top spacing as compared to UI segment empty state

@ankitakinger ankitakinger added IDE Product Issues related to the IDE Product Task A simple Todo IDE Pod Issues that new developers face while exploring the IDE labels Dec 25, 2024
@ankitakinger ankitakinger self-assigned this Dec 25, 2024
ankitakinger added a commit that referenced this issue Dec 25, 2024
… UI segment empty state (#38365)

## Description

Fixing the top padding for queries and JS empty state to match UI
segment empty state

Fixes [#38364](#38364)

## Automation

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12492225163>
> Commit: 7be7180
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12492225163&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE`
> Spec:
> <hr>Wed, 25 Dec 2024 11:07:53 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced conditional rendering of the `BlankState` component to
indicate when there are no items to display.
- Added a `NoSearchResults` component for clearer feedback when searches
yield no results.
- **Bug Fixes**
- Removed redundant rendering of the `BlankState` component to
streamline the user interface.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
NandanAnantharamu pushed a commit that referenced this issue Dec 27, 2024
… UI segment empty state (#38365)

## Description

Fixing the top padding for queries and JS empty state to match UI
segment empty state

Fixes [#38364](#38364)

## Automation

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12492225163>
> Commit: 7be7180
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12492225163&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE`
> Spec:
> <hr>Wed, 25 Dec 2024 11:07:53 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced conditional rendering of the `BlankState` component to
indicate when there are no items to display.
- Added a `NoSearchResults` component for clearer feedback when searches
yield no results.
- **Bug Fixes**
- Removed redundant rendering of the `BlankState` component to
streamline the user interface.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo
Projects
None yet
1 participant