Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updating empty state message when searching items in queries segment #37636

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

ankitakinger
Copy link
Contributor

@ankitakinger ankitakinger commented Nov 21, 2024

Description

Updating empty state message when searching items in queries segment

Fixes #37635

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11953608015
Commit: 7cd8517
Cypress dashboard.
Tags: @tag.Sanity
Spec:


Thu, 21 Nov 2024 13:34:32 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features

    • Updated messaging in the search results for improved clarity when no queries are found.
  • Bug Fixes

    • Corrected the context of the empty search result message from JavaScript objects to queries.

Copy link
Contributor

coderabbitai bot commented Nov 21, 2024

Walkthrough

The changes in this pull request focus on the ListQuery component within the EditorPane. The primary modification involves updating the type prop of the EmptySearchResult component to provide a more accurate message when no search results are found. This change shifts the context from JavaScript objects to queries, reflecting a semantic update in the user interface without altering any underlying logic or control flow.

Changes

File Path Change Summary
app/client/src/pages/Editor/IDE/EditorPane/Query/List.tsx Updated EmptySearchResult component's type prop from search_objects.jsObject to search_objects.queries.

Assessment against linked issues

Objective Addressed Explanation
Update error message for empty search results in Queries segment (#37635)

Possibly related PRs

  • fix: Add pane issues #33627: This PR modifies the AddQuery component, which is related to the ListQuery component in the main PR, as both are part of the query management functionality in the editor.
  • fix: adding branch in url for search entities #36938: This PR updates the EntitySearchBar component, which may interact with the ListQuery component in terms of search functionality, indicating a potential relationship in how queries are handled in the application.

Suggested labels

Bug, UI Improvement, Low, Production, Needs Triaging, ok-to-test, IDE Product

Suggested reviewers

  • hetunandu

🎉 In the realm of code, a change we embrace,
A message refined, now fits its place.
From objects of JavaScript, we now steer,
To queries that matter, loud and clear!
In the editor's heart, a small but bright light,
Guiding the users, making it right! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Bug Something isn't working IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Production labels Nov 21, 2024
@ankitakinger ankitakinger added the ok-to-test Required label for CI label Nov 21, 2024
@ankitakinger ankitakinger merged commit b113cf7 into release Nov 21, 2024
42 checks passed
@ankitakinger ankitakinger deleted the fix/search-error-msg branch November 21, 2024 13:41
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this pull request Nov 27, 2024
…ment (appsmithorg#37636)

## Description

Updating empty state message when searching items in queries segment

Fixes [appsmithorg#37635](appsmithorg#37635)

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11953608015>
> Commit: 7cd8517
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11953608015&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Thu, 21 Nov 2024 13:34:32 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Updated messaging in the search results for improved clarity when no
queries are found.
  
- **Bug Fixes**
- Corrected the context of the empty search result message from
JavaScript objects to queries.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage ok-to-test Required label for CI Production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Incorrect error message is shown in Queries segment when the searched item list is empty
2 participants