-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(install): plugins support APOLLO_ROVER_DOWNLOAD_HOST #1713
feat(install): plugins support APOLLO_ROVER_DOWNLOAD_HOST #1713
Conversation
Co-authored-by: Avery Harnish <[email protected]>
1f13d35
to
c814280
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳 This is why I love open source! Thanks for the contribution and look forward to continuing to improve the project with you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updating my review to request changes as the PR does not compile due to the s/$/&
suggestion above. I'd push the commit myself but since it's a fork I am (reasonably) unable to.
Co-authored-by: Avery Harnish <[email protected]>
also needs a |
Co-authored-by: Avery Harnish <[email protected]>
Until i tried to run the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small suggestion to align to our content style guidelines. Thanks for documenting this!
Do we know when this will be included in a release? It's basically unusable until then since it's a binary 😃 |
Sure - the next release is scheduled for next week. If you desperately need this before then, I recommend building from source. Cloning and running |
Yeah, gotta love Mac's "can't scan this application so we've decided you can't use it" level of harrassment for developers. 🤣 For now, I've built a cargo binary for mac locally and will see if we've got any issues from that ahead of the next release. Does that have a specific date yet, or is it just a milestone with a burn down chart of issues? |
This PR adds the ability for rover plugins to be downloaded through a user-designated mirror/proxy of
rover.apollo.dev
. related #1638, and possibly related: #1253 #1583Documentation was updated for the
npm
section, although this variable is respected for plugin downloads regardless of installation method ofrover
, so additional documentation may be needed at a higher level to address the proxy/mirror pattern of managing rover installations.