Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(install): plugins support APOLLO_ROVER_DOWNLOAD_HOST #1713

Conversation

LongLiveCHIEF
Copy link
Contributor

This PR adds the ability for rover plugins to be downloaded through a user-designated mirror/proxy of rover.apollo.dev. related #1638, and possibly related: #1253 #1583

Documentation was updated for the npm section, although this variable is respected for plugin downloads regardless of installation method of rover, so additional documentation may be needed at a higher level to address the proxy/mirror pattern of managing rover installations.

@LongLiveCHIEF LongLiveCHIEF force-pushed the plugin-install-binary-mirror-support branch from 1f13d35 to c814280 Compare August 17, 2023 16:05
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 This is why I love open source! Thanks for the contribution and look forward to continuing to improve the project with you

@EverlastingBugstopper EverlastingBugstopper added the feature 🎉 new commands, flags, functionality, and improved error messages label Aug 17, 2023
@EverlastingBugstopper EverlastingBugstopper added this to the vNext milestone Aug 17, 2023
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating my review to request changes as the PR does not compile due to the s/$/& suggestion above. I'd push the commit myself but since it's a fork I am (reasonably) unable to.

Co-authored-by: Avery Harnish <[email protected]>
@EverlastingBugstopper
Copy link
Contributor

also needs a cargo fmt --all ran on the codebase

@LongLiveCHIEF
Copy link
Contributor Author

Until i tried to run the cargo xtask lint locally myself just now, I had never heard of volta. Kinda looks like a neat tool, and I will have to see if that has configurable downloads now 🤣

Copy link
Contributor

@Meschreiber Meschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion to align to our content style guidelines. Thanks for documenting this!

docs/source/getting-started.md Show resolved Hide resolved
@LongLiveCHIEF
Copy link
Contributor Author

Do we know when this will be included in a release? It's basically unusable until then since it's a binary 😃

@EverlastingBugstopper
Copy link
Contributor

Sure - the next release is scheduled for next week. If you desperately need this before then, I recommend building from source. Cloning and running cargo xtask package will build a release binary for you using the same process as our CI and dump a tarball in ./artifacts (though note this won't work for our MacOS builds as they are notarized and require secrets that you won't have access to - in that case just run cargo build --release -p rover && ./target/release/rover install to run the install step).

@LongLiveCHIEF
Copy link
Contributor Author

Sure - the next release is scheduled for next week. If you desperately need this before then, I recommend building from source. Cloning and running cargo xtask package will build a release binary for you using the same process as our CI and dump a tarball in ./artifacts (though note this won't work for our MacOS builds as they are notarized and require secrets that you won't have access to - in that case just run cargo build --release -p rover && ./target/release/rover install to run the install step).

Yeah, gotta love Mac's "can't scan this application so we've decided you can't use it" level of harrassment for developers. 🤣

For now, I've built a cargo binary for mac locally and will see if we've got any issues from that ahead of the next release. Does that have a specific date yet, or is it just a milestone with a burn down chart of issues?

@LongLiveCHIEF LongLiveCHIEF deleted the plugin-install-binary-mirror-support branch August 18, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🎉 new commands, flags, functionality, and improved error messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants