docs: clearer docs for plugin download host configuration #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
added
the
docs 📝
Meschreiber
approved these changes
Aug 18, 2023
| @@ -49,9 +49,9 @@ Rover is distributed on npm for integration with your JavaScript projects. | |||
| Internally, the `npm` installer downloads router binaries from `https://rover.apollo.dev`. If this URL is unavailable, for example, in a private network, you can point the `npm` installer at another URL in one of two ways: | |||
|
|
|||
| - by setting the `APOLLO_ROVER_DOWNLOAD_HOST` environment variable | |||
| - *note*: This value must be set if you also want the rover plugins to be downloaded from this host | |||
| - by adding the following to your global or local `.npmrc`: | |||
There was a problem hiding this comment.
By removing this line, there's no longer a reference to the .npmrc so now the snippet below for npmrc config makes no sense.
There was a problem hiding this comment.
oh shoot i didn't mean to do that my bad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Meschreiber I've merged PR #1713 in service of getting the functionality out there and I've opened this PR where we can iterate on the wording - let me know what you think.
cc @LongLiveCHIEF