Field Merging [3/x] Implement in SelectionSetTemplate #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 26, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @AnthonyMDev and the rest of your teammates on |
AnthonyMDev
force-pushed
the
03-21-field_merging_2_x_compute_mergedselections_w_mergingstrategy
branch
from
561c9c4 to
70ea639
Compare
AnthonyMDev
force-pushed
the
Implement_FieldMerging_in_SelectionSetTemplate
branch
from
d8205b4 to
524a720
Compare
This was referenced Apr 24, 2024
AnthonyMDev
changed the title
AnthonyMDev
force-pushed
the
03-21-field_merging_2_x_compute_mergedselections_w_mergingstrategy
branch
from
70ea639 to
36dc2e6
Compare
AnthonyMDev
force-pushed
the
Implement_FieldMerging_in_SelectionSetTemplate
branch
from
524a720 to
5bddba3
Compare
AnthonyMDev
force-pushed
the
03-21-field_merging_2_x_compute_mergedselections_w_mergingstrategy
branch
from
36dc2e6 to
1252393
Compare
AnthonyMDev
force-pushed
the
Implement_FieldMerging_in_SelectionSetTemplate
branch
from
5bddba3 to
288253c
Compare
…o v4.17.2 git-subtree-dir: apollo-ios git-subtree-mainline: 9410d46 git-subtree-split: 8f26d38eccdab79c9aaa7bd5966308a58be6cbf6
8f26d38e Update ROADMAP.md da5ff68f Update ROADMAP.md git-subtree-dir: apollo-ios git-subtree-split: 8f26d38eccdab79c9aaa7bd5966308a58be6cbf6
…rollup to v4.17.2 git-subtree-dir: apollo-ios-codegen git-subtree-mainline: df4667b git-subtree-split: de2b59cc895b6a8063acabbda00833e71295da5e
de2b59cc chore(deps): update dependency rollup to v4.17.2 (#352) git-subtree-dir: apollo-ios-codegen git-subtree-split: de2b59cc895b6a8063acabbda00833e71295da5e
…input field w/default value in schema git-subtree-dir: apollo-ios-codegen git-subtree-mainline: ec3a037 git-subtree-split: a491080fa0d51f680fbbeaaa8bd631c1f764099f
a491080f Generate nil default value for input field w/default value in schema (#358) git-subtree-dir: apollo-ios-codegen git-subtree-split: a491080fa0d51f680fbbeaaa8bd631c1f764099f
23c36434 Update ROADMAP.md git-subtree-dir: apollo-ios git-subtree-split: 23c3643410f46d4198b493bc97e237d7ef35e57e
git-subtree-dir: apollo-ios git-subtree-mainline: a668ecf git-subtree-split: 23c3643410f46d4198b493bc97e237d7ef35e57e
…eTemplate git-subtree-dir: apollo-ios-codegen git-subtree-mainline: fb6c29e git-subtree-split: e26c27b1a19a77f6d599ced10a1ebb386cc5a83f
e26c27b1 Namespace ApolloAPI in InterfaceTemplate (#359) git-subtree-dir: apollo-ios-codegen git-subtree-split: e26c27b1a19a77f6d599ced10a1ebb386cc5a83f
git-subtree-dir: apollo-ios git-subtree-mainline: c1bdf86 git-subtree-split: dbe53502d61cff52a1bd777fc31f04fa75bbd214
dbe53502 [README] Add dark mode logo (#420) git-subtree-dir: apollo-ios git-subtree-split: dbe53502d61cff52a1bd777fc31f04fa75bbd214
e89e65da [README] Add dark mode logo (#420) git-subtree-dir: apollo-ios-pagination git-subtree-split: e89e65da462a6994f4eef54439742a158982433a
git-subtree-dir: apollo-ios-pagination git-subtree-mainline: 9a89224 git-subtree-split: e89e65da462a6994f4eef54439742a158982433a
9b87ee08 fix: Local cache mutation build error in Swift 6 (#417) git-subtree-dir: apollo-ios git-subtree-split: 9b87ee082dfefa4036ce189fdeb5e52b3f952bef
…n Swift 6 git-subtree-dir: apollo-ios git-subtree-mainline: 3497c4a git-subtree-split: 9b87ee082dfefa4036ce189fdeb5e52b3f952bef
fb192097 fix: Local cache mutation build error in Swift 6 (#417) git-subtree-dir: apollo-ios-codegen git-subtree-split: fb1920971dea2158458bd2b1896653edbf934594
… error in Swift 6 git-subtree-dir: apollo-ios-codegen git-subtree-mainline: 571b2ca git-subtree-split: fb1920971dea2158458bd2b1896653edbf934594
AnthonyMDev
force-pushed
the
Implement_FieldMerging_in_SelectionSetTemplate
branch
from
288253c to
391fa0d
Compare
06c1a891 Update ROADMAP.md git-subtree-dir: apollo-ios git-subtree-split: 06c1a89127ba5655243a6a2cd014e418899cd5c7
git-subtree-dir: apollo-ios git-subtree-mainline: 304b53d git-subtree-split: 06c1a89127ba5655243a6a2cd014e418899cd5c7
…tringly typed Codable usage for JSON encoding
AnthonyMDev
force-pushed
the
Implement_FieldMerging_in_SelectionSetTemplate
branch
from
391fa0d to
a3e3b18
Compare
|
Closing. This is replaced by #431 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
SelectionSetTemplateto handle different field merging strategies specified in the configuration options. It also refactors the rendering logic to consider merged fields when generating property accessors, fragment accessors, and selection set initializers. This change ensures that the template can handle merged fields appropriately based on the specified merging strategy.