Generate nil default value for input field w/default value in schema #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
calvincestari
approved these changes
May 14, 2024
BobaFetters
pushed a commit
that referenced
this pull request
May 14, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
May 14, 2024
BobaFetters
pushed a commit
that referenced
this pull request
May 14, 2024
a491080f Generate nil default value for input field w/default value in schema (#358) git-subtree-dir: apollo-ios-codegen git-subtree-split: a491080fa0d51f680fbbeaaa8bd631c1f764099f
BobaFetters
pushed a commit
that referenced
this pull request
May 14, 2024
…input field w/default value in schema git-subtree-dir: apollo-ios-codegen git-subtree-mainline: ec3a037 git-subtree-split: a491080fa0d51f680fbbeaaa8bd631c1f764099f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2997.
The Kotlin codegen generates the parameter for that field with a default value of nil, so that if the user doesn’t pass a value, the field is omitted from the request and the schema side default value is used. This provides parity with Kotlin client functionality.