Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace ApolloAPI in InterfaceTemplate #359

Merged
merged 1 commit into from
May 14, 2024
Merged

Namespace ApolloAPI in InterfaceTemplate #359

merged 1 commit into from
May 14, 2024

Conversation

AnthonyMDev
Copy link
Contributor

Fixes #3375

Interface should be namespaced to ApolloAPI.

@AnthonyMDev AnthonyMDev enabled auto-merge (squash) May 14, 2024 19:39
@netlify Netlify
Copy link

netlify bot commented May 14, 2024 •
edited
Loading

✅ Deploy Preview for apollo-ios-docc canceled.

Name Link
🔨 Latest commit 6fdaec2
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docc/deploys/6643bdeeb938ce0008e22b3f

@netlify Netlify
Copy link

netlify bot commented May 14, 2024 •
edited
Loading

✅ Deploy Preview for eclectic-pie-88a2ba canceled.

Name Link
🔨 Latest commit 6fdaec2
🔍 Latest deploy log https://app.netlify.com/sites/eclectic-pie-88a2ba/deploys/6643bdee7ef03d00093b1c6a

calvincestari
calvincestari approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@calvincestari calvincestari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you. Are we just sticking with fixing Interface for now and wait to see if the others are a problem before a preemptive fix? Union, InputObject and maybe one or two others could have the same problem.

@AnthonyMDev AnthonyMDev merged commit e5e24a4 into main May 14, 2024
25 checks passed
@AnthonyMDev AnthonyMDev deleted the fix-3375 branch May 14, 2024 22:32
BobaFetters pushed a commit that referenced this pull request May 14, 2024
@AnthonyMDev
Namespace ApolloAPI in InterfaceTemplate (#359)
a668ecf
BobaFetters pushed a commit to apollographql/apollo-ios-codegen that referenced this pull request May 14, 2024
@AnthonyMDev
Namespace ApolloAPI in InterfaceTemplate (apollographql/apollo-ios-de…
e26c27b 
…v#359)
BobaFetters pushed a commit that referenced this pull request May 14, 2024
split: apollo-ios - PR #359 - Namespace ApolloAPI in InterfaceTemplate
fb6c29e 
git-subtree-dir: apollo-ios
git-subtree-mainline: a668ecf
git-subtree-split: 23c3643410f46d4198b493bc97e237d7ef35e57e
BobaFetters pushed a commit that referenced this pull request May 14, 2024
Squashed 'apollo-ios-codegen/' changes from a491080f..e26c27b1
fa98a8c 
e26c27b1 Namespace ApolloAPI in InterfaceTemplate (#359)

git-subtree-dir: apollo-ios-codegen
git-subtree-split: e26c27b1a19a77f6d599ced10a1ebb386cc5a83f
BobaFetters pushed a commit that referenced this pull request May 14, 2024
split: apollo-ios-codegen - PR #359 - Namespace ApolloAPI in Interfac…
557a6c2 
…eTemplate

git-subtree-dir: apollo-ios-codegen
git-subtree-mainline: fb6c29e
git-subtree-split: e26c27b1a19a77f6d599ced10a1ebb386cc5a83f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvincestari calvincestari calvincestari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Circular reference Build Error
2 participants
@AnthonyMDev @calvincestari