Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#431] Remove app warnings code from profile #438

Merged
merged 4 commits into from
Nov 4, 2020
Merged

[#431] Remove app warnings code from profile #438

merged 4 commits into from
Nov 4, 2020

Conversation

shadcn
Copy link
Contributor

@shadcn shadcn commented Oct 15, 2020

Fixes #431

⚠️ To be merged after apigee/apigee-edge-drupal#507

@google-cla google-cla bot added the cla: yes Indicates CLA has been signed label Oct 15, 2020
@shadcn shadcn marked this pull request as ready for review October 15, 2020 10:08
@arlina-espinoza
Copy link
Contributor

LGTM, but we need to wait until an apigee_edge release and require the latest version in this module.

@arlina-espinoza
Copy link
Contributor

@arshad Could you please update PR to require the latest version of apigee_edge? It includes the changes from apigee/apigee-edge-drupal#507 Thanks!

@google-cla
Copy link

google-cla bot commented Nov 4, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no Indicates CLA has not been signed and removed cla: yes Indicates CLA has been signed labels Nov 4, 2020
@arlina-espinoza
Copy link
Contributor

@googlebot I consent.

@google-cla google-cla bot added cla: yes Indicates CLA has been signed and removed cla: no Indicates CLA has not been signed labels Nov 4, 2020
@arlina-espinoza arlina-espinoza force-pushed the 431-remove-app-warnings branch from 68c6a65 to 33ac336 Compare November 4, 2020 18:40
arlina-espinoza
arlina-espinoza approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@arlina-espinoza arlina-espinoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it all looks good. Thanks @arshad :)

@arlina-espinoza arlina-espinoza merged commit 4148032 into apigee:8.x-1.x Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arlina-espinoza arlina-espinoza arlina-espinoza approved these changes

Assignees
No one assigned
Labels
cla: yes Indicates CLA has been signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove app warnings code from apigee_kickstart_enhancement.module
2 participants
@shadcn @arlina-espinoza