Remove app warnings code from apigee_kickstart_enhancement.module

[VladimirAus]

Description

Warnings only present when profile is present making module is not fully functional.

Steps to Reproduce

1. Invalidate one of the APIs used by the application.
2. Warning only visible when installation profile is enable

Proposal

Move the code from kickstart into the apigee edge module:

• apigee-devportal-kickstart-drupal/modules/custom/apigee_kickstart_enhancement/apigee_kickstart_enhancement.module

  Lines 110 to 139 in f1672a9

  	// Add warnings to app.
  	foreach (\Drupal::service('apigee_kickstart.enhancer')->getAppEntityTypes() as $entity_type_id => $app_entity_type) {
  	$fields[$entity_type_id][$entity_type_id]['display']['warnings'] = [
  	'label' => t('Warnings'),
  	'weight' => 10,
  	'visible' => FALSE,
  	];
  	}
  	return $fields;
  	}
  	/**
  	* Implements hook_entity_view().
  	*/
  	function apigee_kickstart_enhancement_entity_view(array &$build, EntityInterface $entity, EntityViewDisplayInterface $display, $view_mode) {
  	$entity_type = $entity->getEntityType();
  	if (\Drupal::service('apigee_kickstart.enhancer')
  	->isAppEntityType($entity_type)) {
  	$warnings = _apigee_kickstart_enhancement_check_app_warnings($entity, $entity_type);
  	if (count($warnings)) {
  	$build['warnings'] = [
  	'#theme' => 'status_messages',
  	'#message_list' => [
  	'warning' => $warnings,
  	],
  	];
  	}
  	}
  	}

• apigee-devportal-kickstart-drupal/modules/custom/apigee_kickstart_enhancement/apigee_kickstart_enhancement.module

  Lines 258 to 313 in f1672a9

  	/**
  	* Checks credentials of an app and returns warnings about them.
  	*
  	* TODO: Abstract
  	* \Drupal\apigee_edge\Entity\ListBuilder\AppListBuilder::checkAppCredentialWarnings.
  	*
  	* @param \Drupal\apigee_edge\Entity\AppInterface $app
  	* The app entity to be checked.
  	* @param \Drupal\Core\Entity\EntityTypeInterface $entity_type
  	* The app entity type.
  	*
  	* @return array
  	* An associative array that contains information about the revoked
  	* credentials and revoked or pending API products in a credential.
  	*
  	* @throws \Drupal\Component\Plugin\Exception\InvalidPluginDefinitionException
  	* @throws \Drupal\Component\Plugin\Exception\PluginNotFoundException
  	*/
  	function _apigee_kickstart_enhancement_check_app_warnings(AppInterface $app, EntityTypeInterface $entity_type) {
  	$warnings = [];
  	$warnings['revokedCred'] = FALSE;
  	$warnings['revokedOrPendingCredProduct'] = FALSE;
  	$warnings['expiredCred'] = FALSE;
  	foreach ($app->getCredentials() as $credential) {
  	// Check for expired credentials.
  	if (($expired_date = $credential->getExpiresAt()) && Drupal::time()->getRequestTime() - $expired_date->getTimestamp() > 0) {
  	$warnings['expiredCred'] = t('At least one of the credentials associated with this @app is expired.', [
  	'@app' => mb_strtolower($entity_type->getSingularLabel()),
  	]);
  	}
  	if ($credential->getStatus() === AppCredentialInterface::STATUS_APPROVED) {
  	foreach ($credential->getApiProducts() as $cred_product) {
  	if ($cred_product->getStatus() == CredentialProduct::STATUS_REVOKED || $cred_product->getStatus() == CredentialProduct::STATUS_PENDING) {
  	$args = [
  	'@app' => mb_strtolower($entity_type->getSingularLabel()),
  	'@api_product' => mb_strtolower(Drupal::entityTypeManager()->getDefinition('api_product')->getSingularLabel()),
  	'@status' => $cred_product->getStatus() == CredentialProduct::STATUS_REVOKED ? t('revoked') : t('pending'),
  	];
  	if (count($app->getCredentials()) === 1) {
  	/** @var \Drupal\apigee_edge\Entity\ApiProductInterface $apiProduct */
  	$api_product = Drupal::entityTypeManager()->getStorage('api_product')->load($cred_product->getApiproduct());
  	$args['%name'] = $api_product->label();
  	$warnings['revokedOrPendingCredProduct'] = t('%name @api_product associated with this @app is in @status status.', $args);
  	} else {
  	$warnings['revokedOrPendingCredProduct'] = t('At least one @api_product associated with one of the credentials of this @app is in @status status.', $args);
  	}
  	break;
  	}
  	}
  	}
  	}
  	return array_filter($warnings);
  	}

Apigee edge task: apigee/apigee-edge-drupal#492

[shadcn]

@VladimirAus We're actually reworking this bit.

In apigee/apigee-edge-drupal#446 we removed the warning for revoked credentials. See @cnovak comment below:

Currently the system will show a warning for apps that have revoked credentials. This should not be considered a warning state since revoking credentials is part of the maintenance of an app.

We need to update this kickstart now.

[arunz6161]

After fix in apigee/apigee-edge-drupal#492 , remove the warnings from kickstart.

[shadcn]

@VladimirAus we are going to handle all app warnings in apigee_edge and remove the code from kickstart. I'll update the ticket to reflect this.

Thank you for your help on this. Appreciate it.