Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#492] Refactor app warnings #507

Merged
merged 9 commits into from
Oct 23, 2020

Conversation

shadcn
Copy link
Contributor

@shadcn shadcn commented Oct 13, 2020

Fixes #492

This PR

  1. Adds a warning for appe with all credentials revoked.
  2. Moves the warning checks from the AppListBuilder into a separate service: \Drupal\apigee_edge\Entity\AppWarningsChecker so that it can be re-used (example in Apigee Kickstart).
  3. Adds a Warnings extra field to app entities for showing warnings in entity view displays.

@google-cla google-cla bot added the cla: yes Indicates CLA has been signed label Oct 13, 2020
@shadcn
Copy link
Contributor Author

shadcn commented Oct 13, 2020

I'm still working on this (see draft status). Not ready for review. Thanks @mxr576

@mxr576
Copy link
Contributor

mxr576 commented Oct 14, 2020

I'm still working on this (see draft status). Not ready for review. Thanks @mxr576

Yeah I know, I am just wanted to share my ideas to help to design this.

@google-cla
Copy link

google-cla bot commented Oct 16, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no Indicates CLA has not been signed and removed cla: yes Indicates CLA has been signed labels Oct 16, 2020
@arlina-espinoza
Copy link
Contributor

@googlebot I consent.

@google-cla google-cla bot added cla: yes Indicates CLA has been signed and removed cla: no Indicates CLA has not been signed labels Oct 16, 2020
@arlina-espinoza
Copy link
Contributor

@arshad I made some updates to the AppWarningsCheckerTest and AppListBuilderTest to make sure they also pass when integration is enabled during tests (ie, real API connection).

Copy link
Contributor

@arlina-espinoza arlina-espinoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@arlina-espinoza arlina-espinoza merged commit d46f255 into apigee:8.x-1.x Oct 23, 2020
@mxr576
Copy link
Contributor

mxr576 commented Oct 24, 2020

Raised a new issue as a follow up of a conversion in this PR ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates CLA has been signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application API warnings are not present in apigee edge module
3 participants