chore: Remove Cross Filter scoping modal

[geido]

SUMMARY

• Removes the cross filters scoping modal
• Changes the styles of the filter indicators in slice headers
• Fix an issue with highlighting the emitter chart

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

Verify that cross filters work as intended without the cross filter scoping modal

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags: DASHBOARD_CROSS_FILTERS
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #23216 (e90be7f) into master (a591130) will increase coverage by 11.31%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           master   #23216       +/-   ##
===========================================
+ Coverage   56.22%   67.53%   +11.31%     
===========================================
  Files        1910     1906        -4     
  Lines       73466    73369       -97     
  Branches     7973     7955       -18     
===========================================
+ Hits        41303    49551     +8248     
+ Misses      30115    21774     -8341     
+ Partials     2048     2044        -4     

Flag	Coverage Δ
hive	52.76% <ø> (?)
mysql	78.43% <ø> (?)
postgres	78.49% <ø> (?)
presto	52.69% <ø> (ø)
python	82.26% <ø> (+23.39%)	⬆️
sqlite	76.96% <ø> (?)
unit	52.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...dashboard/components/SliceHeaderControls/index.tsx	72.22% <ø> (+1.81%)	⬆️
...end/src/dashboard/components/SliceHeader/index.tsx	90.56% <50.00%> (+3.06%)	⬆️
...nd/src/dashboard/components/FiltersBadge/index.tsx	85.71% <100.00%> (+0.71%)	⬆️

... and 312 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[kgabryje]

/testenv up FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_HORIZONTAL_FILTER_BAR=true

[github-actions]

@kgabryje Ephemeral environment spinning up at http://34.217.33.133:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[kgabryje]

/testenv up FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_HORIZONTAL_FILTER_BAR=true

[github-actions]

@kgabryje Ephemeral environment spinning up at http://54.71.89.70:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[kgabryje]

I think the spacing here is too big - it's 2*8px but it should be 8px. Other than that and a few nits in the code, looks great!

[kgabryje]

1 more thing - the badge looks a bit weird when >= 10 filters are applied. I wonder if maybe we could change the shape to oval instead of a circle if there are 2 digits? @kasiazjc wdyt?

[kasiazjc]

1 more thing - the badge looks a bit weird when >= 10 filters are applied. I wonder if maybe we could change the shape to oval instead of a circle if there are 2 digits? @kasiazjc wdyt?

Definitely agreed - my bad. Maybe we can just use the pill that is used in the "more filters" dropdown when filters are applied (horizontal filter bar)? (but keeping colors we have here)

[kgabryje]

LGTM

[github-actions]

@eschutho Ephemeral environment spinning up at http://34.214.121.29:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[github-actions]

@eschutho Ephemeral environment spinning up at http://34.214.121.29:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.

[TechAuditBI]

Hi! I'm sorry but why have you deleted cross-filter scoping functionality? It was so useful and allowed to apply some sketchy filtering techniques.

[TechAuditBI]

@geido Sorry for bothering you but I'm really frustrated about this PR and our team would have to do a bunch of work to adapt our current custom functionality to this new reality.

[geido]

@geido Sorry for bothering you but I'm really frustrated about this PR and our team would have to do a bunch of work to adapt our current custom functionality to this new reality.

Hello @TechAuditBI we are aware that this is creating a bit of discomfort and we are acting accordingly. Let me ping a few people for awareness @kasiazjc @yousoph

[TechAuditBI]

@geido Sorry for bothering you but I'm really frustrated about this PR and our team would have to do a bunch of work to adapt our current custom functionality to this new reality.

Hello @TechAuditBI we are aware that this is creating a bit of discomfort and we are acting accordingly. Let me ping a few people for awareness @kasiazjc @yousoph

So did i understand you correctly that you are developing some alternative?

[yousoph]

Hi @TechAuditBI ! I believe that the json metadata (in dashboard properties) can be used to cross filter control scoping for the time being.

Would you be willing to share a bit more about your use case and how you're planning to use the cross filter scoping? Thanks in advance for the additional context!

[TechAuditBI]

Hi @TechAuditBI ! I believe that the json metadata (in dashboard properties) can be used to cross filter control scoping for the time being.

Would you be willing to share a bit more about your use case and how you're planning to use the cross filter scoping? Thanks in advance for the additional context!

Hi! We are mostly using it in situations where we have a bunch of different datasets in one dashboard to cross-filter charts using identically named columns. Usually it is helpful to create separate datasets for filtering in case of working with large amounts of data so that superset does not have to run select distinct queries to get all possible options. It speeds up dashboard loading process. Also we've developed some custom charts which tend to "mimic" filter box functionality via cross-filtering e.g. time filter in a form of slider aspired by such in PBI. And scoping is crucial for it's functionality. All in all i understand that our custom charts should not be a concern for the community. But scoping feature was very useful in a regular dashboard development. If it requires some effort to support scoping in this repository, we are ready to take this responsibility. You may have seen some PRs from @Always-prog he is our developer so we have already commited some of our work to the community and ready to expand our contribution!

[TechAuditBI]

@yousoph Hey! Any thoughts on my comment?

[rusackas]

CC @villebro who had similar wishes for the revival of this feature.

[villebro]

Thanks for pinging @rusackas - yes, I feel strongly about bringing this back, and I will be happy to participate in maintenance of said feature 👍

[yousoph]

Thanks for the context, @TechAuditBI

@kasiazjc and I are going to discuss next steps, will provide another update in a few days

[itaipelles]

Hi!
We were also extensively using this feature and were sad to see it go.
Here's our use case, which I did not see mentioned here as of yet (weird because I thought it's pretty common):
Lets say we have a dashboard displaying events which have a 4 depth classification system:
Component -> Category -> Sub Category -> Sub Sub Category
We have 4 pie charts, one for each classification level, and we use them to drill down into a specific Sub Sub category
We then see a table, and some time series charts, which show only events of this specific classification.
This is working beautifully with the amazing cross dashboard filtering.
Now regarding scoping, we don't want the Category pie chart to apply its filter to the Component pie chart!
The Sub Category pie chart should not apply its filter to both Category and Component
And the Sub Sub Category should not apply its filter to any other pie chart above it.
Otherwise, you get that the pie charts which are above in the classification system show only a single slice, according to what was chosen below it, and it looks pretty funny.

[TechAuditBI]

Hi! We were also extensively using this feature and were sad to see it go. Here's our use case, which I did not see mentioned here as of yet (weird because I thought it's pretty common): Lets say we have a dashboard displaying events which have a 4 depth classification system: Component -> Category -> Sub Category -> Sub Sub Category We have 4 pie charts, one for each classification level, and we use them to drill down into a specific Sub Sub category We then see a table, and some time series charts, which show only events of this specific classification. This is working beautifully with the amazing cross dashboard filtering. Now regarding scoping, we don't want the Category pie chart to apply its filter to the Component pie chart! The Sub Category pie chart should not apply its filter to both Category and Component And the Sub Sub Category should not apply its filter to any other pie chart above it. Otherwise, you get that the pie charts which are above in the classification system show only a single slice, according to what was chosen below it, and it looks pretty funny.

Amazing usecase! Thanks for partisipating!

[yousoph]

Hi all! We discussed the cross filters scoping a bit and we are thinking about bringing it back with the following improvements:

• additional access point to set cross filter scoping from the filter bar settings menu
• allow users to see all cross filter scoping in one place in a cross filter scoping modal and switch between scoping different charts from here
• still allow setting up cross filter scoping by clicking from the chart overflow menu

In addition to the above, we're also considering adding a global cross filter scoping option, so if some charts should not be impacted by any cross filters, that can be set at this global level instead of individually scoped from each emitting chart.

[TechAuditBI]

Hi all! We discussed the cross filters scoping a bit and we are thinking about bringing it back with the following improvements:

• additional access point to set cross filter scoping from the filter bar settings menu
• allow users to see all cross filter scoping in one place in a cross filter scoping modal and switch between scoping different charts from here
• still allow setting up cross filter scoping by clicking from the chart overflow menu

In addition to the above, we're also considering adding a global cross filter scoping option, so if some charts should not be impacted by any cross filters, that can be set at this global level instead of individually scoped from each emitting chart.

Good news!
What is an ETA on this? And do you need any assistance?

[yousoph]

It's in progress, there should be something up in the next week or two :)